From: ToineSiebelink <toine.siebelink@est.tech>
Date: Tue, 6 Apr 2021 15:44:14 +0000 (+0100)
Subject: Fix security hotspots n Regex
X-Git-Tag: 1.1.0~90^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=6e4ce6970552917c0f35617164017d93bd6b2f1b;hp=a3ceacb9ebf11c6467d66c0f42af714ef93591c2;p=cps.git

Fix security hotspots n Regex

Attemting to fix security risks indentified by SQ by reducing unlimited spaces to 0-9 spaces
See https://sonarcloud.io/project/security_hotspots?id=onap_cps#
I think the proposed regex changes are acceptable and better then adding @SupressWarning annotation
(have to test by merging this commit as issues are not spotted when using SonarLinit locally?!)

Issue-ID: CPS-89

Change-Id: I00bbacb3145650ab7d21d13152c08d5ccf0c04fa
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
---

diff --git a/cps-application/src/main/java/org/onap/cps/config/WebSecurityConfig.java b/cps-application/src/main/java/org/onap/cps/config/WebSecurityConfig.java
index fbf1be9a1..93a3a6ed2 100644
--- a/cps-application/src/main/java/org/onap/cps/config/WebSecurityConfig.java
+++ b/cps-application/src/main/java/org/onap/cps/config/WebSecurityConfig.java
@@ -55,7 +55,7 @@ public class WebSecurityConfig extends WebSecurityConfigurerAdapter {
         @Autowired @Value("${security.auth.password}") final String password
     ) {
         super();
-        this.permitUris = permitUris.isEmpty() ? new String[] {"/v3/api-docs"} : permitUris.split("\\s*,\\s*");
+        this.permitUris = permitUris.isEmpty() ? new String[] {"/v3/api-docs"} : permitUris.split("\\s{0,9},\\s{0,9}");
         this.username = username;
         this.password = password;
     }
diff --git a/cps-ri/src/main/java/org/onap/cps/spi/query/CpsPathQuery.java b/cps-ri/src/main/java/org/onap/cps/spi/query/CpsPathQuery.java
index 7b9bfba17..97a304d76 100644
--- a/cps-ri/src/main/java/org/onap/cps/spi/query/CpsPathQuery.java
+++ b/cps-ri/src/main/java/org/onap/cps/spi/query/CpsPathQuery.java
@@ -39,7 +39,8 @@ public class CpsPathQuery {
 
     private static final String NON_CAPTURING_GROUP_1_TO_99_YANG_CONTAINERS = "((?:\\/[^\\/]+){1,99})";
 
-    private static final String YANG_LEAF_VALUE_EQUALS_CONDITION = "\\[\\s*@(\\S+?)\\s*=\\s*(.*?)\\s*\\]";
+    private static final String YANG_LEAF_VALUE_EQUALS_CONDITION =
+        "\\[\\s{0,9}@(\\S+?)\\s{0,9}=\\s{0,9}(.*?)\\s{0,9}\\]";
 
     private static final Pattern QUERY_CPS_PATH_WITH_SINGLE_LEAF_PATTERN =
         Pattern.compile(NON_CAPTURING_GROUP_1_TO_99_YANG_CONTAINERS + YANG_LEAF_VALUE_EQUALS_CONDITION);