From: r.bogacki <r.bogacki@samsung.com>
Date: Fri, 31 May 2019 09:07:46 +0000 (+0200)
Subject: Improvements in AAIClientHelper
X-Git-Tag: 1.5.2~322^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=6d098210b2b6dddbd9bc5594e38779f496d6efbc;p=so.git

Improvements in AAIClientHelper

Improvements in AAIClientHelper according to the Sonar analysis.
Removed unnecessary exception throwing.
Fixed imports.
Updated java docs.

Issue-ID: SO-1958
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I60835304466bb656f09ba16b487907fa529e5eab
---

diff --git a/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/tenantisolation/helpers/AAIClientHelper.java b/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/tenantisolation/helpers/AAIClientHelper.java
index d9db5713a7..6942d441e6 100644
--- a/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/tenantisolation/helpers/AAIClientHelper.java
+++ b/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/tenantisolation/helpers/AAIClientHelper.java
@@ -34,8 +34,6 @@ import org.onap.so.client.aai.entities.AAIResultWrapper;
 import org.onap.so.client.aai.entities.uri.AAIResourceUri;
 import org.onap.so.client.aai.entities.uri.AAIUriFactory;
 import org.onap.so.client.graphinventory.entities.uri.Depth;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.springframework.stereotype.Component;
 
 
@@ -63,7 +61,7 @@ public class AAIClientHelper {
      * Update managing ECOMP Environment Info from A&AI
      * 
      * @param id = operationalEnvironmentId
-     * @param AAIOperationalEnvironment object
+     * @param aaiRequest object
      */
     public void updateAaiOperationalEnvironment(String id, OperationalEnvironment aaiRequest) {
 
@@ -75,7 +73,7 @@ public class AAIClientHelper {
 
 
     public void updateAaiOperationalEnvironment(String operationalEnvironmentId, Map<String, String> payload)
-            throws Exception {
+            throws AAIClientCallFailed {
         try {
             AAIResourceUri uri =
                     AAIUriFactory.createResourceUri(AAIObjectType.OPERATIONAL_ENVIRONMENT, operationalEnvironmentId);
@@ -90,7 +88,7 @@ public class AAIClientHelper {
     /**
      * Create an Operational Environment object in A&AI
      * 
-     * @param AAIOperationalEnvironment object
+     * @param operationalEnvironment object
      */
     public void createOperationalEnvironment(OperationalEnvironment operationalEnvironment) {