From: Tomasz Switon <tomasz.switon@nokia.com>
Date: Thu, 24 May 2018 13:00:52 +0000 (+0200)
Subject: Fix potential errors in ASDCController
X-Git-Tag: v1.3.0~61^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=615725b3dea2275b00d07be9aecbfbb320001ef0;p=so.git

Fix potential errors in ASDCController

Change-Id: Ic9cdc62286cee9a62f3de325a3aa5b3a1008ec5f
Issue-ID: SO-647
Signed-off-by: Switon Tomasz <tomasz.switon@nokia.com>
---

diff --git a/asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCController.java b/asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCController.java
index c452089425..867efd5840 100644
--- a/asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCController.java
+++ b/asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCController.java
@@ -492,17 +492,17 @@ public class ASDCController {
     	try {
     		LOGGER.info(MessageEnum.ASDC_RECEIVE_SERVICE_NOTIF, "***WRITE FILE ARTIFACT NAME", "ASDC", artifact.getArtifactName());
 
-    		FileOutputStream outFile = new FileOutputStream(System.getProperty("mso.config.path") + "/ASDC" + "/" + artifact.getArtifactName());
-    		outFile.write(payloadBytes, 0, payloadBytes.length);
-    		outFile.close();
-    		} catch (Exception e) { 
-    			LOGGER.debug("Exception :",e);
-                LOGGER.error(MessageEnum.ASDC_ARTIFACT_DOWNLOAD_FAIL,
-        				artifact.getArtifactName (),
-        				artifact.getArtifactURL (),
-        				artifact.getArtifactUUID (),
-        				resultArtifact.getDistributionMessageResult (), "", "", MsoLogger.ErrorCode.DataError, "ASDC write to file failed"); 
-            } 
+    		try (FileOutputStream outFile = new FileOutputStream(System.getProperty("mso.config.path") + "/ASDC" + "/" + artifact.getArtifactName())) {
+                outFile.write(payloadBytes, 0, payloadBytes.length);
+    		}
+        } catch (Exception e) {
+            LOGGER.debug("Exception :",e);
+            LOGGER.error(MessageEnum.ASDC_ARTIFACT_DOWNLOAD_FAIL,
+                    artifact.getArtifactName (),
+                    artifact.getArtifactURL (),
+                    artifact.getArtifactUUID (),
+                    resultArtifact.getDistributionMessageResult (), "", "", MsoLogger.ErrorCode.DataError, "ASDC write to file failed");
+        }
     	
     }