From: Jonathan Gathman <jonathan.gathman@att.com>
Date: Thu, 22 Aug 2019 13:21:00 +0000 (+0000)
Subject: Merge "Sonar Fix - Use already-defined constant 'DENIED' instead of duplicating its... 
X-Git-Tag: 2.1.17~163
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=5ba5aa22752660f6cc753ae88a38fb984492d924;hp=4c231d800a0cba774f6bbcaa6ddb40a572d0fe4d;p=aaf%2Fauthz.git

Merge "Sonar Fix - Use already-defined constant 'DENIED' instead of duplicating its value here"
---

diff --git a/auth/auth-cass/src/main/java/org/onap/aaf/auth/dao/cass/ApprovalDAO.java b/auth/auth-cass/src/main/java/org/onap/aaf/auth/dao/cass/ApprovalDAO.java
index 54f57449..7e90bbb9 100644
--- a/auth/auth-cass/src/main/java/org/onap/aaf/auth/dao/cass/ApprovalDAO.java
+++ b/auth/auth-cass/src/main/java/org/onap/aaf/auth/dao/cass/ApprovalDAO.java
@@ -212,7 +212,7 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
             }
             ApprovalLoader.deflt.load(data, rd.value.one());
         }
-        if ("approved".equals(data.status) || "denied".equals(data.status)) { 
+        if (APPROVED.equals(data.status) || DENIED.equals(data.status)) { 
             StringBuilder sb = new StringBuilder("BEGIN BATCH\n");
             sb.append("INSERT INTO ");
             sb.append(TABLELOG);