From: shashikanth <shashikanth.vh@huawei.com>
Date: Thu, 21 Sep 2017 12:02:51 +0000 (+0530)
Subject: Fix Blocker/Critical sonar issues
X-Git-Tag: 1.1.0~25^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=593847a7c7671e5aedc7c465b65051a638465993;p=ccsdk%2Fdashboard.git

Fix Blocker/Critical sonar issues

Fix Blocker/Critical sonar issues in dashboard module
https://sonar.onap.org/component_issues?id=org.onap.oom.dashboard%3Aoom-app-parent#resolved=false|severities=CRITICAL

Fixed Use isEmpty() to check whether the collection is empty or not.

Issue-Id: CCSDK-67
Change-Id: Ib4c04759eb80473232c83c617894ead892531b46
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
---

diff --git a/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java b/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java
index fe54790..7ed3fbe 100644
--- a/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java
+++ b/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java
@@ -72,7 +72,7 @@ public class HealthCheckController extends UnRestrictedBaseController {
 			@SuppressWarnings("unchecked")
 			// Get the single app.
 			List<App> list = dataAccessService.getList(App.class, null);
-			if (list.size() > 0)
+			if (!list.isEmpty())
 				healthStatus = new HealthStatus(200, SystemProperties.getProperty(SystemProperties.APP_DISPLAY_NAME) + " health check succeeded");
 			else
 				healthStatus = new HealthStatus(500, SystemProperties.getProperty(SystemProperties.APP_DISPLAY_NAME) + " health check failed to run db query");