From: Harry Huang <huangxiangyu5@huawei.com>
Date: Sat, 16 Sep 2017 08:48:55 +0000 (+0800)
Subject: fix patch 2
X-Git-Tag: v1.0.0~68
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=536e714bae755a0bfa8eb88064fbaac24afb05cd;p=vnfsdk%2Frefrepo.git

fix patch 2

major: L133 L170
critical: L115 L175

Change-Id: I0a116d160763edb86a3abfb4633487971c7e9a93
Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
Issue-Id: VNFSDK-85
---

diff --git a/vnfmarket-be/vnf-sdk-marketplace/src/main/java/org/onap/vnfsdk/marketplace/wrapper/PackageWrapperUtil.java b/vnfmarket-be/vnf-sdk-marketplace/src/main/java/org/onap/vnfsdk/marketplace/wrapper/PackageWrapperUtil.java
index a763a361..1955f4d3 100644
--- a/vnfmarket-be/vnf-sdk-marketplace/src/main/java/org/onap/vnfsdk/marketplace/wrapper/PackageWrapperUtil.java
+++ b/vnfmarket-be/vnf-sdk-marketplace/src/main/java/org/onap/vnfsdk/marketplace/wrapper/PackageWrapperUtil.java
@@ -113,7 +113,7 @@ public class PackageWrapperUtil {
         result = PackageManager.getInstance().queryPackageByCsarId(csarId).get(0);
       }
     } catch (MarketplaceResourceException e1) {
-      LOG.error("query package by csarId from db error ! " + e1.getMessage());
+      LOG.error("query package by csarId from db error ! " + e1.getMessage(), e1);
     }
     return result;
   }
@@ -130,12 +130,10 @@ public class PackageWrapperUtil {
     PackageMeta packageMeta = new PackageMeta();
     long size = getPacakgeSize(fileLocation);
     packageMeta.setFormat(basic.getFormat());
-    String usedPackageId = null;
+    String usedPackageId = packageId;
     if(null == packageId)
     {
         usedPackageId = ToolUtil.generateId();
-    } else {
-    	usedPackageId = packageId;
     }
 
     packageMeta.setCsarId(usedPackageId);
@@ -167,13 +165,13 @@ public class PackageWrapperUtil {
    * @return download uri
    */
   public static String getPackagePath(String csarId) {
-    ArrayList<PackageData> packageList = new ArrayList<PackageData>();
+    ArrayList<PackageData> packageList = new ArrayList<>();
     String downloadUri = null;
     try {
       packageList = PackageManager.getInstance().queryPackageByCsarId(csarId);
       downloadUri = packageList.get(0).getDownloadUri();
     } catch (MarketplaceResourceException e1) {
-      LOG.error("Query CSAR package by ID failed ! csarId = " + csarId);
+      LOG.error("Query CSAR package by ID failed ! csarId = " + csarId, e1);
     }
     return downloadUri;
   }