From: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Date: Fri, 9 Aug 2019 09:58:30 +0000 (+0200)
Subject: Remove repeated conditional test in ​buildServiceErrorResponse
X-Git-Tag: 1.5.2~88^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=508a13e8add9b8045b55d3325ece076e563ffba9;p=so.git

Remove repeated conditional test in ​buildServiceErrorResponse

Coverity-scan: CID-203826
Issue-ID: SO-2211
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: I18d788e361b502e392f7f59ff6bc772dfee394bd
---

diff --git a/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/tenantisolation/ModelDistributionRequest.java b/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/tenantisolation/ModelDistributionRequest.java
index 216588432b..ef5abe9f74 100644
--- a/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/tenantisolation/ModelDistributionRequest.java
+++ b/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/tenantisolation/ModelDistributionRequest.java
@@ -137,10 +137,8 @@ public class ModelDistributionRequest {
         se.setMessageId(messageId);
         se.setText(text);
         if (variables != null) {
-            if (variables != null) {
-                for (String variable : variables) {
-                    se.getVariables().add(variable);
-                }
+            for (String variable : variables) {
+                se.getVariables().add(variable);
             }
         }
         re.setServiceException(se);