From: shashikanth <shashikanth.vh@huawei.com>
Date: Fri, 8 Sep 2017 13:16:42 +0000 (+0530)
Subject: Fix Blocker/Critical sonar issues
X-Git-Tag: v0.1.0~34
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=4892ec15aadfddd266daa91ccef4d47085a04202;hp=ac453f1bde56bf95b263113fd475ceee80ac9117;p=ccsdk%2Fsli%2Fplugins.git

Fix Blocker/Critical sonar issues

Fix Blocker/Critical sonar issues in vnfapi module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=BLOCKER

Issue-Id: CCSDK-67
Change-Id: I6393ebbaf4bd6dc2dea4a325f2a7d106ba20dd81
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
---

diff --git a/restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java b/restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java
index 7ddeb426..13295741 100644
--- a/restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java
+++ b/restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java
@@ -627,7 +627,7 @@ public class RestapiCallNode implements SvcLogicJavaPlugin {
     }
 
     public void postMessageOnUeb(Map<String, String> paramMap, SvcLogicContext ctx) throws SvcLogicException {
-        HttpResponse r = null;
+        HttpResponse r;
         try {
             UebParam p = getUebParameters(paramMap);
 
@@ -659,7 +659,7 @@ public class RestapiCallNode implements SvcLogicJavaPlugin {
             setResponseStatus(ctx, prefix, r);
         }
 
-        if (r != null && r.code >= 300)
+        if (r.code >= 300)
             throw new SvcLogicException(String.valueOf(r.code) + ": " + r.message);
     }