From: Taka Cho <takamune.cho@att.com>
Date: Wed, 24 Jun 2020 20:24:26 +0000 (-0400)
Subject: sonar fix - FeatureServerPool
X-Git-Tag: 1.7.0~10^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=4744cd180b629a2cf1e44fbe262a1289b19a0caa;p=policy%2Fdrools-pdp.git

sonar fix - FeatureServerPool

- sonar thinks one block of comments are code,
  so changed some syntax in comments
- not more than one break or continue statement

Issue-ID: POLICY-2616
Change-Id: Ia35b73584f5a8492320c4beaa069ba7f903ce268
Signed-off-by: Taka Cho <takamune.cho@att.com>
---

diff --git a/feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/FeatureServerPool.java b/feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/FeatureServerPool.java
index 23da0712..cce7a09d 100644
--- a/feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/FeatureServerPool.java
+++ b/feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/FeatureServerPool.java
@@ -120,8 +120,8 @@ public class FeatureServerPool
      * Example <field-list>: requestID,CommonHeader.RequestID
      *
      * Table generated from this example has length 2:
-     * table[0] = {"requestID"}
-     * table[1] = {"CommonHeader", "RequestID"}
+     * table 0 is "requestID"
+     * table 1 is "CommonHeader", "RequestID"
      */
     private static HashMap<String, String[][]> topicToPaths = new HashMap<>();
 
@@ -319,17 +319,12 @@ public class FeatureServerPool
                 path[path.length - 1] = fieldName;
             }
             keyword = sco.getString(path);
+
             if (keyword != null) {
-                if (conversionFunctionName == null) {
-                    // We found a keyword -- we don't need to try other paths,
-                    // so we should break out of the loop
-                    break;
+                if (conversionFunctionName != null) {
+                    keyword = Keyword.convertKeyword(keyword, conversionFunctionName);
                 }
-
-                // we have post-processing to do
-                keyword = Keyword.convertKeyword(keyword, conversionFunctionName);
                 if (keyword != null) {
-                    // conversion was successful
                     break;
                 }
             }