From: Arundathi Patil <arundpil@in.ibm.com>
Date: Tue, 11 Sep 2018 07:04:18 +0000 (+0530)
Subject: Deny.java: Fixed sonar issues
X-Git-Tag: 2.1.2~50
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=4045b507124fa0314228a1a9152fd0f73d62ed38;hp=c864fd0dd9ac5a3704c883abbb16005aa5b16742;p=aaf%2Fauthz.git

Deny.java: Fixed sonar issues

Sonar Link: https://sonar.onap.org/code?id=org.onap.aaf.authz%3Aparent&selected=org.onap.aaf.authz%3Aaaf-auth-cmd%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Faaf%2Fauth%2Fcmd%2Fmgmt%2FDeny.java

Issue-ID: AAF-479
Change-Id: I1ec8cd407b9d46a8b3129a489c8bdbf805583eab
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
---

diff --git a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/mgmt/Deny.java b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/mgmt/Deny.java
index 159a51bc..47e5b45c 100644
--- a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/mgmt/Deny.java
+++ b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/mgmt/Deny.java
@@ -34,9 +34,9 @@ import org.onap.aaf.cadi.config.Config;
 import org.onap.aaf.misc.env.APIException;
 
 public class Deny extends BaseCmd<Mgmt> {
-    private final static String[] options = {"add","del"};
+    private static final String[] options = {"add","del"};
 
-    public Deny(Mgmt mgmt) throws APIException {
+    public Deny(Mgmt mgmt) {
         super(mgmt, "deny");
         cmds.add(new DenySomething(this,"ip","ipv4or6[,ipv4or6]*"));
         cmds.add(new DenySomething(this,"id","identity[,identity]*"));
@@ -54,8 +54,8 @@ public class Deny extends BaseCmd<Mgmt> {
         }
 
         @Override
-        protected int _exec(int _idx, String... args) throws CadiException, APIException, LocatorException {
-                int idx = _idx;
+        protected int _exec(int idxValue, String... args) throws CadiException, APIException, LocatorException {
+                int idx = idxValue;
             String action = args[idx++];
             final int option = whichOption(options, action);
             int rv=409;
@@ -73,20 +73,20 @@ public class Deny extends BaseCmd<Mgmt> {
                         int rv = 409;
                         Future<Void> fp;
                         String resp;
-                        switch(option) {
-                            case 0: 
-                                fp = client.create(path, Void.class);
-                                resp = " added";
-                                break;
-                            default: 
-                                fp = client.delete(path, Void.class);
-                                resp = " deleted";
+                        if(option == 0) {
+                        	fp = client.create(path, Void.class);
+                            resp = " added";
+                        } else {
+                        	fp = client.delete(path, Void.class);
+                            resp = " deleted";
                         }
                         if (fp.get(AAFcli.timeout())) {
                             pw().println(name + append + resp + " on " + client);
                             rv=fp.code();
                         } else {
-                            if (rv==409)rv = fp.code();
+                            if (rv==409) { 
+                            	rv = fp.code();
+                            };
                             error(fp);
                         }
                         return rv;