From: Surendra Reddy Katam Date: Wed, 8 Aug 2018 07:17:14 +0000 (+0530) Subject: Sonar major issues X-Git-Tag: 1.1.7~26 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=39f80cabccf8a33c22c66a10c583cdbbb9d6e95f;p=dmaap%2Fmessagerouter%2Fdmaapclient.git Sonar major issues Use isEmpty() to check whether the collection is empty or not Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbOi32hFUzlqc5Vg&resolved=false&severities=MAJOR Location: src/main/java/com/att/nsa/mr/client/HostSelector.java Line No-130 Change-Id: Iab107c06d9463f42d34d98fff1073b4a358f7681 Issue-ID: DMAAP-567" Signed-off-by: Surendra Reddy Katam --- diff --git a/src/main/java/com/att/nsa/mr/client/HostSelector.java b/src/main/java/com/att/nsa/mr/client/HostSelector.java index 0dba1e7..63ef404 100644 --- a/src/main/java/com/att/nsa/mr/client/HostSelector.java +++ b/src/main/java/com/att/nsa/mr/client/HostSelector.java @@ -127,7 +127,7 @@ public class HostSelector workingSet.remove(be.getHost()); } - if (workingSet.size() == 0) + if (workingSet.isEmpty()) { log.warn("All hosts were blacklisted; reverting to full set of hosts."); workingSet.addAll(this.fBaseHosts);