From: danielhanrahan <daniel.hanrahan@est.tech>
Date: Fri, 18 Oct 2024 10:19:04 +0000 (+0100)
Subject: Update SpotBugs dependency
X-Git-Tag: 3.5.5~58
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=369017c7fba4c2444e2594215f2b511290e39950;p=cps.git

Update SpotBugs dependency

- update spotbugs to 4.8.6
- remove old findbugs dependency (spotbugs replaces findbugs)
- remove an unused SupressFBWarnings

Issue-ID: CPS-2458
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If9d5571ae4293a2653a117a988414af2452647c0
---

diff --git a/cps-dependencies/pom.xml b/cps-dependencies/pom.xml
index ab145370af..a95e5f42b0 100644
--- a/cps-dependencies/pom.xml
+++ b/cps-dependencies/pom.xml
@@ -131,12 +131,7 @@
             <dependency>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs-annotations</artifactId>
-                <version>3.1.3</version>
-            </dependency>
-            <dependency>
-                <groupId>com.google.code.findbugs</groupId>
-                <artifactId>annotations</artifactId>
-                <version>3.0.1</version>
+                <version>4.8.6</version>
             </dependency>
             <dependency>
                 <groupId>com.google.code.gson</groupId>
diff --git a/cps-ncmp-service/pom.xml b/cps-ncmp-service/pom.xml
index 9f7bb08a07..fda4221f6f 100644
--- a/cps-ncmp-service/pom.xml
+++ b/cps-ncmp-service/pom.xml
@@ -73,10 +73,6 @@
             <groupId>${project.groupId}</groupId>
             <artifactId>cps-path-parser</artifactId>
         </dependency>
-        <dependency>
-            <groupId>com.google.code.findbugs</groupId>
-            <artifactId>annotations</artifactId>
-        </dependency>
         <dependency>
             <groupId>com.hazelcast</groupId>
             <artifactId>hazelcast-spring</artifactId>
diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/utils/http/WebClientConfiguration.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/utils/http/WebClientConfiguration.java
index d8e8350345..8ae942eb7b 100644
--- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/utils/http/WebClientConfiguration.java
+++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/utils/http/WebClientConfiguration.java
@@ -20,7 +20,6 @@
 
 package org.onap.cps.ncmp.impl.utils.http;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.netty.channel.ChannelOption;
 import io.netty.handler.timeout.ReadTimeoutHandler;
 import io.netty.handler.timeout.WriteTimeoutHandler;
@@ -63,7 +62,6 @@ public class WebClientConfiguration {
                 .compress(true);
     }
 
-    @SuppressFBWarnings("BC_UNCONFIRMED_CAST_OF_RETURN_VALUE")
     private static ConnectionProvider getConnectionProvider(final ServiceConfig serviceConfig) {
         return ConnectionProvider.builder(serviceConfig.getConnectionProviderName())
                 .maxConnections(serviceConfig.getMaximumConnectionsTotal())