From: edyta Date: Thu, 2 Apr 2020 08:57:18 +0000 (+0200) Subject: Fix sonar secure issue RandomPasswordGenerator X-Git-Tag: 1.0.0~11 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=30aa650ccfbd6dd2e98d2a1001e418c2a3c39fd3;p=oom%2Fplatform%2Fcert-service.git Fix sonar secure issue RandomPasswordGenerator Issue-ID: AAF-1118 Signed-off-by: Edyta Krukowska Change-Id: I687b4af22ae07ce6d0bbbc5abfdf53635f30f54f --- diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/conversion/RandomPasswordGenerator.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/conversion/RandomPasswordGenerator.java index 5db7b26f..aa7d6151 100644 --- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/conversion/RandomPasswordGenerator.java +++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/conversion/RandomPasswordGenerator.java @@ -33,7 +33,11 @@ class RandomPasswordGenerator { private static final boolean USE_LETTERS_ONLY = false; private static final boolean USE_NUMBERS_ONLY = false; + // We are excluding this line in Sonar due to fact that + //we are using new SecureRandom which provides + //cryptographic security Password generate(int passwordLength) { + //NOSONAR return new Password(RandomStringUtils.random( passwordLength, START_POSITION_IN_ASCII_CHARS,