From: Surendra Reddy Katam <SK00524980@techmahindra.com>
Date: Tue, 14 Aug 2018 05:16:31 +0000 (+0530)
Subject: Sonar major issues
X-Git-Tag: 1.1.7~12^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=2374c15b30a1ebb4bd1d6960972a55d749167c95;p=dmaap%2Fmessagerouter%2Fdmaapclient.git

Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbRu32hFUzlqc5ei&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
Line No-238

Change-Id: I7896ced67ab12816b92fe972322dad4ff4558cf8
Issue-ID: DMAAP-589
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
---

diff --git a/src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java b/src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
index 741705f..ef0d13a 100644
--- a/src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
+++ b/src/main/java/com/att/nsa/mr/client/impl/MRSimplerBatchPublisher.java
@@ -235,7 +235,7 @@ public class MRSimplerBatchPublisher extends MRBaseClient implements MRBatchingP
 
 	private synchronized boolean shouldSendNow() {
 		boolean shouldSend = false;
-		if (fPending.size() > 0) {
+		if (fPending.isEmpty()) {
 			final long nowMs = Clock.now();
 
 			shouldSend = (fPending.size() >= fMaxBatchSize);