From: shashikanth <shashikanth.vh@huawei.com>
Date: Mon, 18 Sep 2017 09:59:53 +0000 (+0530)
Subject: Fix Blocker/Critical sonar issues
X-Git-Tag: v1.2.0~72
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=1a9f177416ef1dab33c54e3d08fdbaa26e88034c;p=appc.git

Fix Blocker/Critical sonar issues

Fix Blocker/Critical sonar issues in appc module
https://sonar.onap.org/component_issues?id=org.openecomp.appc%3Aappc#resolved=false|severities=BLOCKER

Redundent if condition removed from DGGeneralDBService.java

Issue-Id: APPC-92
Change-Id: I9b963759e562dc0744b3742a70905a417c3c444a
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
---

diff --git a/appc-config/appc-data-services/provider/src/main/java/org/openecomp/appc/data/services/db/DGGeneralDBService.java b/appc-config/appc-data-services/provider/src/main/java/org/openecomp/appc/data/services/db/DGGeneralDBService.java
index 87995fe85..1b63d75e9 100644
--- a/appc-config/appc-data-services/provider/src/main/java/org/openecomp/appc/data/services/db/DGGeneralDBService.java
+++ b/appc-config/appc-data-services/provider/src/main/java/org/openecomp/appc/data/services/db/DGGeneralDBService.java
@@ -417,7 +417,7 @@ public class DGGeneralDBService {
          QueryStatus status = null;
          SvcLogicContext localContext = new SvcLogicContext();
          localContext.setAttribute("vnf-type", vnf_type);
-         if (serviceLogic != null && localContext  != null) {
+         if (serviceLogic != null) {
                  String queryString = "select max(internal_version) as maxInternalVersion, artifact_name as artifactName from ASDC_ARTIFACTS " +
                                   " where artifact_name in (select artifact_name from ASDC_REFERENCE  where vnf_type= $vnf-type "  +
                              " and file_category = 'capability' )" ;