From: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
Date: Sun, 19 May 2024 08:17:22 +0000 (+0200)
Subject: ErrorLogHelper is not parsing all error codes
X-Git-Tag: 1.14.0~4
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=17cf0fc2bd8ead53beadafe0fda7605fbb27f618;p=aai%2Faai-common.git

ErrorLogHelper is not parsing all error codes

- do not parse error codes as int

Issue-ID: AAI-3853
Change-Id: I4cad636c58fbe14f59aecc8692f7c96d50686d18
Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
---

diff --git a/aai-els-onap-logging/src/main/java/org/onap/aai/logging/ErrorLogHelper.java b/aai-els-onap-logging/src/main/java/org/onap/aai/logging/ErrorLogHelper.java
index 97548d99..bb2fe268 100644
--- a/aai-els-onap-logging/src/main/java/org/onap/aai/logging/ErrorLogHelper.java
+++ b/aai-els-onap-logging/src/main/java/org/onap/aai/logging/ErrorLogHelper.java
@@ -383,8 +383,7 @@ public class ErrorLogHelper {
     }
 
     private static ErrorObject getRestErrorObject(AAIException aaiException) {
-        final int restErrorCode = Integer.parseInt(aaiException.getErrorObject().getRESTErrorCode());
-        return ErrorLogHelper.getErrorObject("AAI_" + restErrorCode);
+        return ErrorLogHelper.getErrorObject("AAI_" + aaiException.getErrorObject().getRESTErrorCode());
     }
 
     public static Fault createPolicyFault(AAIException aaiException, String text, List<String> variables) {
diff --git a/aai-els-onap-logging/src/test/java/org/onap/aai/logging/ErrorLogHelperTest.java b/aai-els-onap-logging/src/test/java/org/onap/aai/logging/ErrorLogHelperTest.java
index ea9d44b9..73890a0a 100644
--- a/aai-els-onap-logging/src/test/java/org/onap/aai/logging/ErrorLogHelperTest.java
+++ b/aai-els-onap-logging/src/test/java/org/onap/aai/logging/ErrorLogHelperTest.java
@@ -265,7 +265,7 @@ public class ErrorLogHelperTest {
         Info info = ErrorLogHelper.getRestApiInfoResponse(aaiExceptionsMap);
         ErrorMessage errorMessage = info.getErrorMessages().get(0);
         assertEquals("INF0001", errorMessage.getMessageId());
-        assertEquals("Internal Error (msg=%1) (ec=%2)", errorMessage.getText());
+        assertEquals("Success X-FromAppId=%1 X-TransactionId=%2 (msg=%3) (ec=%4)", errorMessage.getText());
         assertEquals("Successful health check:OK", errorMessage.getVariables().get(0));
         assertEquals("0.0.0002", errorMessage.getVariables().get(1));
     }