From: shashikanth <shashikanth.vh@huawei.com>
Date: Tue, 26 Sep 2017 12:30:38 +0000 (+0530)
Subject: Fixed string literal comparision issue
X-Git-Tag: v1.1.0~241^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=154b169929fbd9003fe4d04db301e65ecf29e553;p=so.git

Fixed string literal comparision issue

Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143

Move the "extracted information" string literal on the left side of this string comparison.

Issue-Id: APPC-186
Change-Id: I757599f5c8ebcbe70c86105c335c6195e436486b
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
---

diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java
index 4bee115411..b775999116 100644
--- a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java
+++ b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java
@@ -215,7 +215,7 @@ public class ServiceDecomposition extends JsonWrapper implements Serializable {
 			Resource resource = iter.next();
 			//resource.getModelInfo().getModelInvariantId();
 
-			if (resourceObjectId.equals("extracted information")){
+			if ("extracted information".equals(resourceObjectId)){
 				return resource.toJsonString();
 			}
 		}