From: Chris André <chris.andre@yoppworks.com>
Date: Thu, 16 Apr 2020 00:18:59 +0000 (-0400)
Subject: Simplified thread-safety for the `getGson` method
X-Git-Tag: 1.7.0~230
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=1491bd0d20906819481c8d334e5d4d1639fadb8c;p=sdc.git

Simplified thread-safety for the `getGson` method

Issue-ID: SDC-2900
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I8c687bb408a5e0b1e95316bdae6d53126bc82696
---

diff --git a/common-app-api/src/main/java/org/openecomp/sdc/common/util/GsonFactory.java b/common-app-api/src/main/java/org/openecomp/sdc/common/util/GsonFactory.java
index 7c3bcb6cad..882422ba4a 100644
--- a/common-app-api/src/main/java/org/openecomp/sdc/common/util/GsonFactory.java
+++ b/common-app-api/src/main/java/org/openecomp/sdc/common/util/GsonFactory.java
@@ -26,13 +26,9 @@ import com.google.gson.GsonBuilder;
 public class GsonFactory {
 	private static Gson gson = null;
 
-	public static Gson getGson() {
+	public static synchronized Gson getGson() {
 		if (gson == null) {
-			synchronized (GsonFactory.class) {
-				if (gson == null) {
 					gson = new GsonBuilder().disableHtmlEscaping().serializeNulls().create();
-				}
-			}
 		}
 
 		return gson;