From: Sandeep J <sandeejh@in.ibm.com>
Date: Mon, 3 Dec 2018 10:30:48 +0000 (+0530)
Subject: fixed sonar issues in RestServiceImpl.java
X-Git-Tag: 0.4.0~55^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=10abe761bed97607d59a6f113dfd766d6c411105;p=ccsdk%2Fapps.git

fixed sonar issues in RestServiceImpl.java

fixed sonar issues

Issue-ID: CCSDK-525
Change-Id: I2f37d883df71b48daa0f0daf8b57d3c609889a52
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
---

diff --git a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/service/rs/RestServiceImpl.java b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/service/rs/RestServiceImpl.java
index e52e0016..3746756e 100644
--- a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/service/rs/RestServiceImpl.java
+++ b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/service/rs/RestServiceImpl.java
@@ -42,7 +42,9 @@ import org.springframework.web.bind.annotation.RequestBody;
 public class RestServiceImpl implements RestService {
     private static Logger log = Logger.getLogger(RestServiceImpl.class.getName());
     private static final String INTERNAL_ERROR_MSG = "Internal error occured while processing the request.";
-
+    private static final String ERROR="error";
+    
+    
     @Autowired SpringService service;
 
     /**
@@ -67,11 +69,11 @@ public class RestServiceImpl implements RestService {
             return buildResponse(resp);
         } catch (NengException e) {
             log.warning(e.getMessage());
-            response.put("error", buildErrorResponse("NELGEN-0003", e.getMessage()));
+            response.put(ERROR, buildErrorResponse("NELGEN-0003", e.getMessage()));
             return buildErrorResponse(response);
         } catch (Exception e) {
             log.warning(e.getMessage());
-            response.put("error", buildErrorResponse("err-0500", INTERNAL_ERROR_MSG));
+            response.put(ERROR, buildErrorResponse("err-0500", INTERNAL_ERROR_MSG));
             return buildErrorResponse(response);
         }
     }
@@ -88,11 +90,11 @@ public class RestServiceImpl implements RestService {
             return buildResponse(resp);
         } catch (NengException e) {
             log.warning(e.getMessage());
-            response.put("error", buildErrorResponse("NELGEN-0002", e.getMessage()));
+            response.put(ERROR, buildErrorResponse("NELGEN-0002", e.getMessage()));
             return buildErrorResponse(response);
         } catch (Exception e) {
             log.warning(e.getMessage());
-            response.put("error", buildErrorResponse("err-0500", INTERNAL_ERROR_MSG));
+            response.put(ERROR, buildErrorResponse("err-0500", INTERNAL_ERROR_MSG));
             return buildErrorResponse(response);
         }
     }
@@ -120,7 +122,7 @@ public class RestServiceImpl implements RestService {
             return buildResponse(response);
         } catch (Exception e) {
             log.warning(e.getMessage());
-            response.put("error", buildErrorResponse("err-0500", e.getMessage()));
+            response.put(ERROR, buildErrorResponse("err-0500", e.getMessage()));
             return buildErrorResponse(response);
         }
     }