From: Krzysztof Opasiak <k.opasiak@samsung.com>
Date: Wed, 30 Jan 2019 13:10:35 +0000 (+0100)
Subject: Fix potential race condition
X-Git-Tag: 1.4.0~60
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=0c59da823026c29d6a7c243c74e8f858c20b8f75;p=policy%2Fcommon.git

Fix potential race condition

init() is currently called outside of synhronized block.
This is may lead to race condition as init() creates new bus consumer
(this.consumer) which is the copied and nulled in stop() synchronized
block. This may lead to race condition if:

Thread #1   	     	     	       Thread #2

this.alive = true;
					this.alive = false
					consumerCopy = this.consumer;

this.consumer = new Consumer();

					// false
					if(consumerCopy != null) {
					    consumerCopy.close();
					} else {
					    log.warn();
					}

As a result, new BusConsumers are being created but they are never
close().

Issue-ID: POLICY-1387
Change-Id: I2eadb12ef1c4b07b9e47dc6ebc096acc713299a0
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
---

diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineBusTopicSink.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineBusTopicSink.java
index 93896898..d6ca824e 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineBusTopicSink.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineBusTopicSink.java
@@ -93,10 +93,10 @@ public abstract class InlineBusTopicSink extends BusTopicBase implements BusTopi
                 throw new IllegalStateException(this + " is locked.");
             }
 
+            this.init();
             this.alive = true;
         }
 
-        this.init();
         return true;
     }