From: Sindhuri.A <arcot.sindhuri@huawei.com>
Date: Sat, 20 Apr 2019 11:09:50 +0000 (+0530)
Subject: Move String literal to left-hand side of equals
X-Git-Tag: 1.5.2~438^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=0923081aa89349576665e56a0895ede48da9813e;p=so.git

Move String literal to left-hand side of equals

Move String literal to left-hand side of equals SniroValidator class

Issue-ID: SO-1490

Change-Id: Ib9d1ba94908f92cc46cf5a8177e3808327398600
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
---

diff --git a/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/client/sniro/SniroValidator.java b/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/client/sniro/SniroValidator.java
index a448082cfe..eb73001f42 100644
--- a/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/client/sniro/SniroValidator.java
+++ b/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/client/sniro/SniroValidator.java
@@ -49,7 +49,7 @@ public class SniroValidator {
             JSONObject jsonResponse = new JSONObject(response);
             if (jsonResponse.has("requestStatus")) {
                 String status = jsonResponse.getString("requestStatus");
-                if (status.equals("accepted")) {
+                if ("accepted".equals(status)) {
                     logger.debug("Sniro Managers synchronous response indicates accepted");
                 } else {
                     String message = jsonResponse.getString("statusMessage");
@@ -111,7 +111,7 @@ public class SniroValidator {
         if (!response.isEmpty()) {
             String status = (String) response.get("status");
             if (isNotBlank(status)) {
-                if (status.equals("success")) {
+                if ("success".equals(status)) {
                     logger.debug("Sniro Conductors synchronous response indicates success");
                 } else {
                     String message = (String) response.get("message");