From: Munir Ahmad <munir.ahmad@bell.ca>
Date: Thu, 16 Apr 2020 16:00:19 +0000 (-0400)
Subject: Add additional null checks when building pserver objects from
X-Git-Tag: 1.7.1~208^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=07ce5295b9bdb628cfb67f41026a30470942ce61;p=so.git

Add additional null checks when building pserver objects from
openstack server object. This error is not reproduceable with
mitaka and queens release of openstack

    Issue-ID: SO-2802

Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Change-Id: I8c7a31d98ba4ef05faaf07ded0da13120fddf2c7
---

diff --git a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java
index 4df58484d8..390ed38764 100644
--- a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java
+++ b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java
@@ -277,6 +277,9 @@ public class HeatBridgeImpl implements HeatBridgeApi {
     @Override
     public void createPserversAndPinterfacesIfNotPresentInAai(final List<Resource> stackResources)
             throws HeatBridgeException {
+        if (stackResources == null) {
+            return;
+        }
         Map<String, Pserver> serverHostnames = getPserverMapping(stackResources);
         createPServerIfNotExists(serverHostnames);
         List<String> portIds =
@@ -293,8 +296,13 @@ public class HeatBridgeImpl implements HeatBridgeApi {
     private Map<String, Pserver> getPserverMapping(final List<Resource> stackResources) {
         List<Server> osServers = getAllOpenstackServers(stackResources);
         Map<String, Pserver> pserverMap = new HashMap<>();
-        for (Server server : osServers) {
-            pserverMap.put(server.getHost(), aaiHelper.buildPserver(server));
+        if (osServers != null) {
+            for (Server server : osServers) {
+                Pserver pserver = aaiHelper.buildPserver(server);
+                if (pserver != null) {
+                    pserverMap.put(server.getHost(), pserver);
+                }
+            }
         }
         return pserverMap;
     }
diff --git a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java
index adcde92917..727cdccff5 100644
--- a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java
+++ b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java
@@ -146,6 +146,9 @@ public class AaiHelper {
      * @return AAI Pserver object
      */
     public Pserver buildPserver(final Server server) {
+        if (server == null || server.getHypervisorHostname() == null) {
+            return null;
+        }
         Pserver pserver = new Pserver();
         pserver.setInMaint(false);
         pserver.setHostname(server.getHypervisorHostname());