From: Arundathi Patil <arundpil@in.ibm.com>
Date: Wed, 2 Jan 2019 11:19:38 +0000 (+0530)
Subject: Sonar fix: AllocationItemJdbcDaoImpl.java
X-Git-Tag: 0.4.0~8^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=0799be7db42fd7de638b4888e27e1e517691cec5;p=ccsdk%2Fsli%2Fadaptors.git

Sonar fix: AllocationItemJdbcDaoImpl.java

Fixed sonar issues/code-smells across this file

Issue-ID: CCSDK-891
Change-Id: Iaea16ae96c919ad09eb7de31119a9bd14e2ef539
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
---

diff --git a/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/AllocationItemJdbcDaoImpl.java b/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/AllocationItemJdbcDaoImpl.java
index fcde0f8f..2a62c63a 100644
--- a/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/AllocationItemJdbcDaoImpl.java
+++ b/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/AllocationItemJdbcDaoImpl.java
@@ -4,6 +4,7 @@
  * ================================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights
  *                         reserved.
+ * Modifications Copyright © 2018 IBM.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -110,7 +111,7 @@ public class AllocationItemJdbcDaoImpl implements AllocationItemJdbcDao {
         }
 
         if (resourceShareGroupFilter != null) {
-            if (resourceShareGroupFilter.equalsIgnoreCase("null")) {
+            if (("null").equalsIgnoreCase(resourceShareGroupFilter)) {
                 sql += " AND resource_share_group_list IS NULL";
             } else {
                 sql += " AND resource_share_group_list LIKE '" + resourceShareGroupFilter + "'";