From: Surendra Reddy Katam Date: Tue, 3 Apr 2018 13:13:56 +0000 (+0530) Subject: Sonar critical issues X-Git-Tag: v1.1.4~4 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=04fcb5d8366ec866c1417d1b8063ca4e4aaf5765;p=dmaap%2Fmessagerouter%2Fdmaapclient.git Sonar critical issues Define and throw a dedicated exception instead of using a generic one Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQa32hFUzlqc5Zc&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java Line No-78 Change-Id: Ic9fa6e30b450ea1400be0cf8de237eeefdaeb34f Issue-ID: DMAAP-383 Signed-off-by: Surendra Reddy Katam --- diff --git a/src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java b/src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java index 1310986..eb39e8f 100644 --- a/src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java +++ b/src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java @@ -75,7 +75,7 @@ public class MRBatchPublisher implements MRBatchingPublisher try { fSender = new Sender ( baseUrls, topic, maxBatchSize, maxAgeMs, compress ); } catch (MalformedURLException e) { - throw new RuntimeException(e); + throw new IllegalArgumentException(e); } // FIXME: this strategy needs an overhaul -- why not just run a thread that knows how to wait for