From: arkadiusz.adamski Date: Tue, 23 Mar 2021 18:29:25 +0000 (+0000) Subject: Fix sonar issues X-Git-Tag: 2.6.0~71^2 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=003fbb232dd3752bfdeeefdd0ba337f4dc92e0ea;p=policy%2Fapex-pdp.git Fix sonar issues - fix method name on ApexModel Issue-ID: POLICY-3093 Signed-off-by: arkadiusz.adamski Change-Id: I853de0f48bbe683249b4c60c4189fb053c5c12a2 --- diff --git a/model/model-api/src/main/java/org/onap/policy/apex/model/modelapi/ApexModel.java b/model/model-api/src/main/java/org/onap/policy/apex/model/modelapi/ApexModel.java index 9771b6186..6c37e453c 100644 --- a/model/model-api/src/main/java/org/onap/policy/apex/model/modelapi/ApexModel.java +++ b/model/model-api/src/main/java/org/onap/policy/apex/model/modelapi/ApexModel.java @@ -34,7 +34,7 @@ public interface ApexModel extends ApexEditorApi { * * @return the result of the operation */ - ApexModel clone(); + ApexModel getCopy(); /** * Load an Apex model from a string. diff --git a/model/model-api/src/main/java/org/onap/policy/apex/model/modelapi/impl/ApexModelImpl.java b/model/model-api/src/main/java/org/onap/policy/apex/model/modelapi/impl/ApexModelImpl.java index 655bd6ae5..e66322801 100644 --- a/model/model-api/src/main/java/org/onap/policy/apex/model/modelapi/impl/ApexModelImpl.java +++ b/model/model-api/src/main/java/org/onap/policy/apex/model/modelapi/impl/ApexModelImpl.java @@ -87,7 +87,7 @@ public final class ApexModelImpl implements ApexModel { * {@inheritDoc}. */ @Override - public ApexModel clone() { + public ApexModel getCopy() { ApexModelImpl ret = new ApexModelImpl(); // @formatter:off ret.policyModel = new AxPolicyModel(policyModel); diff --git a/model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexModelApiTest.java b/model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexModelApiTest.java index 4071803a0..a4b42276a 100644 --- a/model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexModelApiTest.java +++ b/model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexModelApiTest.java @@ -239,7 +239,7 @@ public class ApexModelApiTest { assertEquals(ApexApiResult.Result.SUCCESS, result.getResult()); assertNotEquals(0, apexModelImpl.hashCode()); - assertNotNull(apexModelImpl.clone()); + assertNotNull(apexModelImpl.getCopy()); assertNotNull(apexModelImpl.build()); } }