From: Pamela Dragosh <pdragosh@research.att.com>
Date: Tue, 30 Jan 2018 13:28:25 +0000 (-0500)
Subject: Fix technical debt and reduce lines
X-Git-Tag: v1.2.0~175^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;ds=sidebyside;h=3ee17bad27b036a9e4ca6e50a7fbdfe2ed0a8e7f;hp=3ee17bad27b036a9e4ca6e50a7fbdfe2ed0a8e7f;p=policy%2Fengine.git

Fix technical debt and reduce lines

Focused on iterating over entrySet along with more fixes for
dead stores, unnecessary exceptions. I'm also starting to work
on reducing the number of code lines.

* Iterate using entrySet
* Remove useless assignments
* Unnecessary exceptions
* Use StringBuilder instead of StringBuffer due to synchronization
* Potential null exceptions being thrown
* Returning a empty collection vs null

Issue-ID: POLICY-482
Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
---