From: surya-huawei <a.u.surya@huawei.com>
Date: Sun, 17 Sep 2017 17:55:14 +0000 (+0530)
Subject: Fix Sonar Issue in sli/plugins module
X-Git-Tag: v0.1.0~29
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;ds=sidebyside;h=342453d02784a1bd791848db8af9e3f927710ec0;hp=9342e92c2557dfc7df213b37e3957f282342b2eb;p=ccsdk%2Fsli%2Fplugins.git

Fix Sonar Issue in sli/plugins module

One major issue
* move string literal to left side
of string comparison

Issue-Id: CCSDK-87

Change-Id: I1277c4c5515bd45ad6854c63cf6160f17b7725d0
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
---

diff --git a/restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java b/restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java
index 4984d1bc..ca227c72 100644
--- a/restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java
+++ b/restapi-call-node/provider/src/main/java/org/onap/ccsdk/sli/plugins/restapicall/RestapiCallNode.java
@@ -559,7 +559,7 @@ public class RestapiCallNode implements SvcLogicJavaPlugin {
         p.httpMethod = HttpMethod.fromString(parseParam(paramMap, "httpMethod", false, "post"));
         p.responsePrefix = parseParam(paramMap, "responsePrefix", false, null);
         String skipSendingStr = paramMap.get("skipSending");
-        p.skipSending = skipSendingStr != null && skipSendingStr.equalsIgnoreCase("true");
+        p.skipSending = "true".equalsIgnoreCase(skipSendingStr);
         return p;
     }