From: Driptaroop Das <driptaroop.das@in.ibm.com>
Date: Wed, 10 Apr 2019 10:35:20 +0000 (+0530)
Subject: Cred.java - Sonar fixes
X-Git-Tag: 2.1.11~5^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;ds=sidebyside;h=2cbabb68ede4416fdf132758e8364566d5cca743;p=aaf%2Fauthz.git

Cred.java - Sonar fixes

Cred.java - Sonar fixes

Issue-ID: AAF-807
Change-Id: Ie7e07c55f6777feac4da6b1d26e2b0ea5463059b
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
---

diff --git a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/user/Cred.java b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/user/Cred.java
index cc9ccf98..d41f0cf3 100644
--- a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/user/Cred.java
+++ b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/user/Cred.java
@@ -38,7 +38,6 @@ public class Cred extends Cmd {
     public static final String ATTEMPT_FAILED_SPECIFICS_WITHELD = "Attempt Failed.  Specifics witheld.";
     private static final String CRED_PATH = "/authn/cred";
     private static final String[] options = {"add","del","reset","extend"/*,"clean"*/};
-//        private Clean clean;
     public Cred(User parent) {
         super(parent,"cred",
                 new Param(optionsToString(options),true),
@@ -46,7 +45,6 @@ public class Cred extends Cmd {
                 new Param("password (! D|E)",false),
                 new Param("entry# (if multi)",false)
         );
-//            clean = new Clean(this);
     }
 
     @Override
@@ -62,11 +60,10 @@ public class Cred extends Cmd {
             cr.setPassword(args[idx++]);
         }
         if (args.length>idx)
-            cr.setEntry(args[idx++]);
+            cr.setEntry(args[idx]);
         
         // Set Start/End commands
         setStartEnd(cr);
-//            final int cleanIDX = _idx+1;
         Integer ret = same(new Retryable<Integer>() {
             @Override
             public Integer code(Rcli<?> client) throws CadiException, APIException {
@@ -82,7 +79,6 @@ public class Cred extends Cmd {
                         verb = "Added Credential [";
                         break;
                     case 1:
-//                            if (aafcli.addForce())cr.setForce("TRUE");
                         setQueryParamsOn(client);
                         fp = client.delete(CRED_PATH,
                             getDF(CredRequest.class),
@@ -106,8 +102,8 @@ public class Cred extends Cmd {
                             );
                         verb = "Extended Credential [";
                         break;
-//                        case 4:
-//                            return clean.exec(cleanIDX, args);
+                    default:
+                        break;
                 }
                 if (fp==null) {
                     return null; // get by Sonar check.