From: Sandeep J <sandeejh@in.ibm.com>
Date: Fri, 24 Aug 2018 12:22:19 +0000 (+0530)
Subject: removed redundant object assignment
X-Git-Tag: 1.4.0~56
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;ds=sidebyside;h=26e6e36b31017efcb8b3bf38f126ce47412b78f5;p=appc.git

removed redundant object assignment

removed PropertyDefinition object creation dependency. The object is
already defined in the setUp method.

Issue-ID: APPC-1086
Change-Id: Icb7e791109a409af1b646b07052bc43517d09dc5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
---

diff --git a/appc-config/appc-config-params/provider/src/test/java/org/onap/sdnc/config/params/parser/TestPropertyDefinitionNode.java b/appc-config/appc-config-params/provider/src/test/java/org/onap/sdnc/config/params/parser/TestPropertyDefinitionNode.java
index 4c0b60272..569fb9eb2 100644
--- a/appc-config/appc-config-params/provider/src/test/java/org/onap/sdnc/config/params/parser/TestPropertyDefinitionNode.java
+++ b/appc-config/appc-config-params/provider/src/test/java/org/onap/sdnc/config/params/parser/TestPropertyDefinitionNode.java
@@ -53,7 +53,6 @@ public class TestPropertyDefinitionNode {
 
     @Test
     public void testProcessMissingParamKeys() throws Exception {
-        PropertyDefinitionNode propertyDefinitionNode = new PropertyDefinitionNode();
         Map<String, String> inParams = new HashMap<String, String>();
         inParams.put(ParamsHandlerConstant.INPUT_PARAM_RESPONSE_PRIFIX, "test");
 
@@ -76,7 +75,6 @@ public class TestPropertyDefinitionNode {
 
     @Test(expected = SvcLogicException.class)
     public void testInProcessMissingParamKeysForEmptyPdContent() throws Exception {
-        PropertyDefinitionNode propertyDefinitionNode = new PropertyDefinitionNode();
         Map<String, String> inParams = new HashMap<String, String>();
         inParams.put(ParamsHandlerConstant.INPUT_PARAM_RESPONSE_PRIFIX, "test");
         String jsonData = IOUtils.toString(
@@ -90,7 +88,6 @@ public class TestPropertyDefinitionNode {
 
     @Test
     public void testProcessExternalSystemParamKeys() throws Exception {
-        PropertyDefinitionNode propertyDefinitionNode = new PropertyDefinitionNode();
         Map<String, String> inParams = new HashMap<String, String>();
         inParams.put(ParamsHandlerConstant.INPUT_PARAM_RESPONSE_PRIFIX, "test");
 
@@ -132,7 +129,6 @@ public class TestPropertyDefinitionNode {
 
     @Test
     public void mergeJsonData() throws Exception {
-        PropertyDefinitionNode propertyDefinitionNode = new PropertyDefinitionNode();
         Map<String, String> inParams = new HashMap<String, String>();
         inParams.put(ParamsHandlerConstant.INPUT_PARAM_RESPONSE_PRIFIX, "test");
 
@@ -157,7 +153,6 @@ public class TestPropertyDefinitionNode {
     @Test
     public void mergeJsonDataForEmptyParams() throws SvcLogicException, IOException {
 
-        PropertyDefinitionNode propertyDefinitionNode = new PropertyDefinitionNode();
         Map<String, String> inParams = new HashMap<String, String>();
         inParams.put(ParamsHandlerConstant.INPUT_PARAM_RESPONSE_PRIFIX, "test");
         String mergeJsonData = IOUtils.toString(
@@ -192,7 +187,6 @@ public class TestPropertyDefinitionNode {
 
     @Test
     public void testValidationPd() throws Exception {
-        PropertyDefinitionNode propertyDefinitionNode = new PropertyDefinitionNode();
         Map<String, String> inParams = new HashMap<String, String>();
         SvcLogicContext ctx = new SvcLogicContext();
         String jsonData = IOUtils.toString(
@@ -210,7 +204,6 @@ public class TestPropertyDefinitionNode {
     @Test(expected=SvcLogicException.class)
     public void testValidateParamsForEmptyParams() throws Exception
     {
-        PropertyDefinitionNode propertyDefinitionNode = new PropertyDefinitionNode();
         Map<String, String> inParams = new HashMap<String, String>();
         SvcLogicContext ctx = new SvcLogicContext();
         propertyDefinitionNode.validateParams(inParams, ctx);