Fix sonar issues in MusicProperties

Change-Id: I9ee0819cdbf97c00347019ef213b037c5d5d5b3a
Issue-ID: PORTAL-523
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>

diff --git a/ecomp-sdk/epsdk-music/src/main/java/org/onap/portalapp/music/util/MusicProperties.java b/ecomp-sdk/epsdk-music/src/main/java/org/onap/portalapp/music/util/MusicProperties.java
index 9aae977..3a03b38 100644 (file)
--- a/ecomp-sdk/epsdk-music/src/main/java/org/onap/portalapp/music/util/MusicProperties.java
+++ b/ecomp-sdk/epsdk-music/src/main/java/org/onap/portalapp/music/util/MusicProperties.java
@@ -121,8 +121,6 @@ public class MusicProperties {
        public static final String EXPIRY_TIME = "EXPIRY_TIME";
        
        public static final String PRINCIPAL_NAME = "PRINCIPAL_NAME";
-       
-       private MusicProperties(){}
 
        private static Properties properties;
        
@@ -132,6 +130,7 @@ public class MusicProperties {
        
        private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(MusicProperties.class);
 
+       private MusicProperties(){}
        /**
         * Gets the property value for the specified key. If a value is found, leading
         * and trailing space is trimmed.
@@ -185,40 +184,5 @@ public class MusicProperties {
                }
                return true;
        }
-       
-       /**
-        * Tests whether a property value is available for the specified key.
-        * 
-        * @param key
-        *            Property key
-        * @return True if the key is known, otherwise false.
-        */
-/*     public static boolean containsProperty(String key) {
-               return environment.containsProperty(key);
-       }*/
-
-       /**
-        * Returns the property value associated with the given key (never
-        * {@code null}), after trimming any trailing space.
-        * 
-        * @param key
-        *            Property key
-        * @return Property value; the empty string if the environment was not
-        *         autowired, which should never happen.
-        * @throws IllegalStateException
-        *             if the key is not found
-        */
-/*     public static String getProperty(String key) {
-               String value = "";
-               if (environment == null) {
-               //      logger.error(EELFLoggerDelegate.errorLogger, "getProperty: environment is null, should never happen!");
-               } else {
-                       value = environment.getRequiredProperty(key);
-                       // java.util.Properties preserves trailing space
-                       if (value != null)
-                               value = value.trim();
-               }
-               return value;
-       }*/
 
 }