Add PolicyService UT 92/130592/1
authorChuanyuChen <chenchuanyu@huawei.com>
Thu, 1 Sep 2022 07:36:40 +0000 (15:36 +0800)
committerChuanyuChen <chenchuanyu@huawei.com>
Thu, 1 Sep 2022 07:36:40 +0000 (15:36 +0800)
Add PolicyService UT

Issue-ID: USECASEUI-716

Signed-off-by: ChuanyuChen <chenchuanyu@huawei.com>
Change-Id: I81b4211f579238343f42da579eebb87b1d460f81

intentanalysis/src/main/java/org/onap/usecaseui/intentanalysis/adapters/policy/impl/PolicyServiceImpl.java
intentanalysis/src/test/java/org/onap/usecaseui/intentanalysis/test/adapters/policy/PolicyServiceTest.java [new file with mode: 0644]
intentanalysis/src/test/java/org/onap/usecaseui/intentanalysis/test/util/TestCall.java [new file with mode: 0644]

index 984afc5..d51d338 100644 (file)
@@ -52,6 +52,10 @@ public class PolicyServiceImpl implements PolicyService {
         return this.policyAPICall;
     }
 
+    public void setPolicyAPICall(PolicyAPICall policyAPICall) {
+        this.policyAPICall = policyAPICall;
+    }
+
     @Override
     public boolean createAndDeployModifyCLLPolicy() {
         try {
@@ -62,8 +66,8 @@ public class PolicyServiceImpl implements PolicyService {
             RequestBody policyReq = RequestBody.create(MediaType.parse("application/json"), policyBody.toString());
             Response<ResponseBody> policyResponse = getPolicyAPICall().createPolicy(ModifyCLLPolicyConstants.policyType,
                 ModifyCLLPolicyConstants.policyTypeVersion, policyReq).execute();
-            logger.info(
-                String.format("Create policy result, code: %d body: %s", policyResponse.code(), policyResponse.body()));
+            logger.info(String.format("Create policy result, code: %d body: %s", policyResponse.code(),
+                getResponseBodyStr(policyResponse)));
             if (!policyResponse.isSuccessful()) {
                 logger.error("Create modify cll policy failed.");
                 return false;
@@ -77,7 +81,7 @@ public class PolicyServiceImpl implements PolicyService {
                 deployPolicyBody.toString());
             Response<ResponseBody> deployPolicyResponse = getPolicyAPICall().deployPolicy(deployPolicyReq).execute();
             logger.info(String.format("Deploy policy result, code: %d body: %s", deployPolicyResponse.code(),
-                deployPolicyResponse.body()));
+                getResponseBodyStr(deployPolicyResponse)));
             if (!deployPolicyResponse.isSuccessful()) {
                 logger.error("Deploy modify cll policy failed.");
                 return false;
@@ -135,8 +139,8 @@ public class PolicyServiceImpl implements PolicyService {
             RequestBody policyTypeReq = RequestBody.create(MediaType.parse("application/json"),
                 policyTypeBody.toString());
             Response<ResponseBody> response = getPolicyAPICall().createPolicyType(policyTypeReq).execute();
-            logger.info(
-                String.format("Create policy type result, code: %d body: %s", response.code(), response.body()));
+            logger.info(String.format("Create policy type result, code: %d body: %s", response.code(),
+                getResponseBodyStr(response)));
             if (!response.isSuccessful()) {
                 logger.error("Create intent configuration policy type failed.");
                 return false;
@@ -149,10 +153,11 @@ public class PolicyServiceImpl implements PolicyService {
                 .replace("${ORIGINAL_BW}", originalBW);
             logger.info(String.format("Create policy, request body: %s", policyBody));
             RequestBody policyReq = RequestBody.create(MediaType.parse("application/json"), policyBody.toString());
-            Response<ResponseBody> policyResponse = getPolicyAPICall().createPolicy(IntentConfigPolicyConstants.policyType,
-                IntentConfigPolicyConstants.policyTypeVersion, policyReq).execute();
-            logger.info(
-                String.format("Create policy result, code: %d body: %s", policyResponse.code(), policyResponse.body()));
+            Response<ResponseBody> policyResponse = getPolicyAPICall().createPolicy(
+                    IntentConfigPolicyConstants.policyType, IntentConfigPolicyConstants.policyTypeVersion, policyReq)
+                .execute();
+            logger.info(String.format("Create policy result, code: %d body: %s", policyResponse.code(),
+                getResponseBodyStr(policyResponse)));
             if (!policyResponse.isSuccessful()) {
                 logger.error("Create intent configuration policy failed.");
                 return false;
@@ -166,7 +171,7 @@ public class PolicyServiceImpl implements PolicyService {
                 deployPolicyBody.toString());
             Response<ResponseBody> deployPolicyResponse = getPolicyAPICall().deployPolicy(deployPolicyReq).execute();
             logger.info(String.format("Deploy policy result, code: %d body: %s", deployPolicyResponse.code(),
-                deployPolicyResponse.body()));
+                getResponseBodyStr(deployPolicyResponse)));
             if (!deployPolicyResponse.isSuccessful()) {
                 logger.error("Deploy intent configuration policy failed.");
                 return false;
@@ -190,17 +195,19 @@ public class PolicyServiceImpl implements PolicyService {
             //check if the policy exists
             Response<ResponseBody> response = getPolicyAPICall().getPolicy(policyType, policyTypeVersion, policyName,
                 policyVersion).execute();
-            logger.info(String.format("The policy query result, code: %d body: %s", response.code(), response.body()));
+            logger.info(String.format("The policy query result, code: %d body: %s", response.code(),
+                getResponseBodyStr(response)));
             // remove the policy if exists.
             if (response.isSuccessful()) {
                 logger.info("The policy exists, start to undeploy.");
                 Response<ResponseBody> undeployResponse = getPolicyAPICall().undeployPolicy(policyName).execute();
                 logger.info(String.format("Undeploy policy result. code: %d body: %s", undeployResponse.code(),
-                    undeployResponse.body()));
+                    getResponseBodyStr(undeployResponse)));
                 logger.info("Start to remove the policy.");
-                Response<ResponseBody> removeResponse = getPolicyAPICall().removePolicy(policyName, policyVersion).execute();
+                Response<ResponseBody> removeResponse = getPolicyAPICall().removePolicy(policyName, policyVersion)
+                    .execute();
                 logger.info(String.format("Remove policy result. code: %d body: %s", removeResponse.code(),
-                    removeResponse.body()));
+                    getResponseBodyStr(removeResponse)));
                 return true;
             }
             return true;
@@ -211,4 +218,11 @@ public class PolicyServiceImpl implements PolicyService {
         }
 
     }
+
+    private String getResponseBodyStr(Response<ResponseBody> response) throws IOException {
+        if (response.body() != null) {
+            return response.body().string();
+        }
+        return null;
+    }
 }
diff --git a/intentanalysis/src/test/java/org/onap/usecaseui/intentanalysis/test/adapters/policy/PolicyServiceTest.java b/intentanalysis/src/test/java/org/onap/usecaseui/intentanalysis/test/adapters/policy/PolicyServiceTest.java
new file mode 100644 (file)
index 0000000..11084e3
--- /dev/null
@@ -0,0 +1,182 @@
+/*
+ * Copyright 2022 Huawei Technologies Co., Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.onap.usecaseui.intentanalysis.test.adapters.policy;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+
+import java.io.IOException;
+import mockit.MockUp;
+import okhttp3.MediaType;
+import okhttp3.ResponseBody;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.onap.usecaseui.intentanalysis.adapters.policy.apicall.PolicyAPICall;
+import org.onap.usecaseui.intentanalysis.adapters.policy.impl.PolicyServiceImpl;
+import org.onap.usecaseui.intentanalysis.test.IntentAnalysisApplicationTests;
+import org.onap.usecaseui.intentanalysis.test.util.TestCall;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.test.context.junit4.SpringRunner;
+
+@SpringBootTest(classes = IntentAnalysisApplicationTests.class)
+@RunWith(SpringRunner.class)
+public class PolicyServiceTest {
+
+    private static final int CREATE_POLICY_TYPE_FAILED = 0x01;
+
+    private static final int CREATE_POLICY_FAILED = 0x02;
+
+    private static final int DEPLOY_POLICY_FAILED = 0x04;
+
+    private static final int UNDEPLOY_POLICY_FAILED = 0x08;
+
+    private static final int DELETE_POLICY_FAILED = 0x10;
+
+    private static final int QUERY_POLICY_NOT_EXIST = 0x20;
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(PolicyServiceTest.class);
+
+    @Autowired
+    private PolicyServiceImpl policyService;
+
+    private PolicyAPICall policyAPICall;
+
+    private MockUp mockup;
+
+    @Test
+    public void testCreateAndDeployCLLPolicySuccess() throws IOException {
+        mockUpPolicyApiCall(0);
+        boolean result = policyService.createAndDeployModifyCLLPolicy();
+        Assert.assertTrue(result);
+    }
+
+
+    @Test
+    public void testCreateAndDeployCLLPolicyFailedCreateFailed() throws IOException {
+        mockUpPolicyApiCall(CREATE_POLICY_FAILED);
+        boolean result = policyService.createAndDeployModifyCLLPolicy();
+        Assert.assertFalse(result);
+    }
+
+    @Test
+    public void testCreateAndDeployCLLPolicyFailedDeployFailed() throws IOException {
+        mockUpPolicyApiCall(DEPLOY_POLICY_FAILED);
+        boolean result = policyService.createAndDeployModifyCLLPolicy();
+        Assert.assertFalse(result);
+    }
+
+    @Test
+    public void testUndeployAndRemoveCLLPolicySuccess() throws IOException {
+        mockUpPolicyApiCall(0);
+        boolean result = policyService.undeployAndRemoveModifyCLLPolicy();
+        Assert.assertTrue(result);
+    }
+
+    @Test
+    public void testUndeployAndRemoveCLLPolicySuccessPolicyNotExist() throws IOException {
+        mockUpPolicyApiCall(QUERY_POLICY_NOT_EXIST);
+        boolean result = policyService.undeployAndRemoveModifyCLLPolicy();
+        Assert.assertTrue(result);
+    }
+
+    @Test
+    public void testUpdateIntentConfigPolicySuccess() throws IOException {
+        mockUpPolicyApiCall(0);
+        boolean result = policyService.updateIntentConfigPolicy("testCLLID", "1000", true);
+        Assert.assertTrue(result);
+    }
+
+    @Test
+    public void testUpdateIntentConfigPolicySuccessPolicyNotExist(){
+        mockUpPolicyApiCall(QUERY_POLICY_NOT_EXIST);
+        boolean result = policyService.updateIntentConfigPolicy("testCLLID", "1000", true);
+        Assert.assertTrue(result);
+    }
+
+    @Test
+    public void testUpdateIntentConfigPolicyFailedCreatePolicyTypeFailed(){
+        mockUpPolicyApiCall(CREATE_POLICY_TYPE_FAILED);
+        boolean result = policyService.updateIntentConfigPolicy("testCLLID", "1000", true);
+        Assert.assertFalse(result);
+    }
+
+    @Test
+    public void testUpdateIntentConfigPolicyFailedCreatePolicyFailed(){
+        mockUpPolicyApiCall(CREATE_POLICY_FAILED);
+        boolean result = policyService.updateIntentConfigPolicy("testCLLID", "1000", true);
+        Assert.assertFalse(result);
+    }
+
+    @Test
+    public void testUpdateIntentConfigPolicyFailedDeployPolicyFailed(){
+        mockUpPolicyApiCall(DEPLOY_POLICY_FAILED);
+        boolean result = policyService.updateIntentConfigPolicy("testCLLID", "1000", true);
+        Assert.assertFalse(result);
+    }
+
+    private void mockUpPolicyApiCall(int failedFlag) {
+        policyAPICall = mock(PolicyAPICall.class);
+        policyService.setPolicyAPICall(policyAPICall);
+        ResponseBody mockedSuccessResponse = ResponseBody.create(MediaType.parse("application/json"),
+            "Test Success Result");
+        if ((CREATE_POLICY_FAILED & failedFlag) > 0) {
+            when(policyAPICall.createPolicy(anyString(), anyString(), any())).thenReturn(
+                TestCall.failedCall("Create policy failed"));
+        } else {
+            when(policyAPICall.createPolicy(anyString(), anyString(), any())).thenReturn(
+                TestCall.successfulCall(mockedSuccessResponse));
+        }
+        if ((CREATE_POLICY_TYPE_FAILED & failedFlag) > 0) {
+            when(policyAPICall.createPolicyType(any())).thenReturn(TestCall.failedCall("Create policy type failed"));
+        } else {
+            when(policyAPICall.createPolicyType(any())).thenReturn(TestCall.successfulCall(mockedSuccessResponse));
+        }
+
+        if ((DEPLOY_POLICY_FAILED & failedFlag) > 0) {
+            when(policyAPICall.deployPolicy(any())).thenReturn(TestCall.failedCall("Deploy policy failed"));
+        } else {
+            when(policyAPICall.deployPolicy(any())).thenReturn(TestCall.successfulCall(mockedSuccessResponse));
+        }
+
+        if ((UNDEPLOY_POLICY_FAILED & failedFlag) > 0) {
+            when(policyAPICall.undeployPolicy(anyString())).thenReturn(TestCall.failedCall("Undeploy policy failed"));
+        } else {
+            when(policyAPICall.undeployPolicy(anyString())).thenReturn(TestCall.successfulCall(mockedSuccessResponse));
+        }
+
+        if ((DELETE_POLICY_FAILED & failedFlag) > 0) {
+            when(policyAPICall.removePolicy(anyString(), anyString())).thenReturn(
+                TestCall.failedCall("Delete policy failed"));
+        } else {
+            when(policyAPICall.removePolicy(anyString(), anyString())).thenReturn(
+                TestCall.successfulCall(mockedSuccessResponse));
+        }
+
+        if ((QUERY_POLICY_NOT_EXIST & failedFlag) > 0) {
+            when(policyAPICall.getPolicy(anyString(), anyString(), anyString(), anyString())).thenReturn(
+                TestCall.failedCall("Get policy failed"));
+        } else {
+            when(policyAPICall.getPolicy(anyString(), anyString(), anyString(), anyString())).thenReturn(
+                TestCall.successfulCall(mockedSuccessResponse));
+        }
+    }
+}
diff --git a/intentanalysis/src/test/java/org/onap/usecaseui/intentanalysis/test/util/TestCall.java b/intentanalysis/src/test/java/org/onap/usecaseui/intentanalysis/test/util/TestCall.java
new file mode 100644 (file)
index 0000000..d9cc4a8
--- /dev/null
@@ -0,0 +1,92 @@
+/*
+ * Copyright 2022 Huawei Technologies Co., Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.onap.usecaseui.intentanalysis.test.util;
+
+import java.io.IOException;
+import okhttp3.MediaType;
+import okhttp3.Request;
+import okhttp3.ResponseBody;
+import retrofit2.Call;
+import retrofit2.Callback;
+import retrofit2.Response;
+
+public class TestCall<T> implements Call<T> {
+
+    private int code;
+
+    private T result;
+
+    private String errorMsg;
+
+    private TestCall(int code, T result, String errorMsg) {
+        this.code = code;
+        this.result = result;
+        this.errorMsg = errorMsg;
+    }
+
+    @Override
+    public Response<T> execute() throws IOException {
+        if (code >= 200 && code < 300) {
+            return Response.success(code, result);
+        }
+        if (code >= 400 && code < 500) {
+            return Response.error(code, ResponseBody.create(MediaType.parse("application/json"), errorMsg));
+        }
+        throw new IOException("Exception happens");
+    }
+
+    public static <T> TestCall<T> successfulCall(T result) {
+        return new TestCall<>(200, result, null);
+    }
+
+    public static <T> TestCall<T> failedCall(String errorMsg) {
+        return new TestCall<>(400, null, errorMsg);
+    }
+
+    public static <T> TestCall<T> exceptionCall() {
+        return new TestCall<>(-1, null, null);
+    }
+
+    @Override
+    public void enqueue(Callback<T> callback) {
+
+    }
+
+    @Override
+    public boolean isExecuted() {
+        return false;
+    }
+
+    @Override
+    public void cancel() {
+
+    }
+
+    @Override
+    public boolean isCanceled() {
+        return false;
+    }
+
+    @Override
+    public Call<T> clone() {
+        return null;
+    }
+
+    @Override
+    public Request request() {
+        return null;
+    }
+
+}