Upgrade Java 17 87/135787/1
authorFrancescoFioraEst <francesco.fiora@est.tech>
Mon, 21 Aug 2023 13:35:56 +0000 (14:35 +0100)
committerFrancesco Fiora <francesco.fiora@est.tech>
Tue, 22 Aug 2023 09:05:59 +0000 (09:05 +0000)
Issue-ID: POLICY-4803
Change-Id: Ic7852fffa2f5a2f407900e7caae9e70bd50b267f
Signed-off-by: FrancescoFioraEst <francesco.fiora@est.tech>
14 files changed:
main/pom.xml
main/src/main/java/org/onap/policy/distribution/main/rest/DistributionRestController.java
main/src/test/java/org/onap/policy/distribution/main/parameters/CommonTestData.java
main/src/test/java/org/onap/policy/distribution/main/rest/TestDistributionRestServer.java
main/src/test/java/org/onap/policy/distribution/main/rest/TestHttpsDistributionRestServer.java
plugins/forwarding-plugins/src/main/java/org/onap/policy/distribution/forwarding/lifecycle/api/LifecycleApiAutomationCompositionForwarder.java
plugins/forwarding-plugins/src/main/java/org/onap/policy/distribution/forwarding/lifecycle/api/LifecycleApiPolicyForwarder.java
plugins/forwarding-plugins/src/test/java/org/onap/policy/distribution/forwarding/testclasses/LifecycleApiAutomationCompositionSimulatorEndpoint.java
plugins/forwarding-plugins/src/test/java/org/onap/policy/distribution/forwarding/testclasses/LifecycycleApiSimulatorEndpoint.java
plugins/reception-plugins/src/test/java/org/onap/policy/distribution/reception/decoding/policy/file/AutomationCompositionDecoderFileInCsarTest.java
plugins/reception-plugins/src/test/java/org/onap/policy/distribution/reception/decoding/policy/file/PolicyDecoderFileInCsarToPolicyTest.java
plugins/reception-plugins/src/test/java/org/onap/policy/distribution/reception/handling/file/TestFileSystemReceptionHandler.java
plugins/reception-plugins/src/test/java/org/onap/policy/distribution/reception/handling/sdc/TestSdcReceptionHandler.java
pom.xml

index 37a889b..7eb0083 100644 (file)
             <groupId>com.google.code.gson</groupId>
             <artifactId>gson</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.swagger</groupId>
+            <artifactId>swagger-annotations</artifactId>
+            <version>1.6.11</version>
+        </dependency>
         <dependency>
             <groupId>org.onap.policy.common</groupId>
             <artifactId>utils-test</artifactId>
index 702f8a2..e9e4b04 100644 (file)
@@ -26,11 +26,11 @@ import io.swagger.annotations.ApiOperation;
 import io.swagger.annotations.Info;
 import io.swagger.annotations.SwaggerDefinition;
 import io.swagger.annotations.Tag;
-import javax.ws.rs.GET;
-import javax.ws.rs.Path;
-import javax.ws.rs.Produces;
-import javax.ws.rs.core.MediaType;
-import javax.ws.rs.core.Response;
+import jakarta.ws.rs.GET;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
 import org.onap.policy.common.endpoints.report.HealthCheckReport;
 
 /**
index 9f6fab5..57fa97d 100644 (file)
@@ -130,6 +130,22 @@ public class CommonTestData {
         }
     }
 
+    /**
+     * Returns an instance of ReceptionHandlerParameters for test cases.
+     *
+     * @param port the port
+     * @return the restServerParameters object
+     */
+    public RestServerParameters getRestServerParameters(final int port) {
+        final var fileName = "src/test/resources/parameters/RestServerParameters.json";
+        try {
+            var json = Files.readString(new File(fileName).toPath());
+            return coder.decode(json.replace("6969", String.valueOf(port)), RestServerParameters.class);
+        } catch (final Exception exp) {
+            throw new RuntimeException("cannot read/decode " + fileName, exp);
+        }
+    }
+
     /**
      * Returns an instance of ReceptionHandlerParameters for test cases.
      *
index ce4cda2..ec4b001 100644 (file)
@@ -28,17 +28,16 @@ import static org.assertj.core.api.Assertions.assertThatCode;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
+import jakarta.ws.rs.client.Client;
+import jakarta.ws.rs.client.ClientBuilder;
+import jakarta.ws.rs.client.Invocation;
+import jakarta.ws.rs.client.WebTarget;
+import jakarta.ws.rs.core.MediaType;
 import java.io.IOException;
-import javax.ws.rs.client.Client;
-import javax.ws.rs.client.ClientBuilder;
-import javax.ws.rs.client.Invocation;
-import javax.ws.rs.client.WebTarget;
-import javax.ws.rs.core.MediaType;
 import org.glassfish.jersey.client.ClientConfig;
 import org.glassfish.jersey.client.authentication.HttpAuthenticationFeature;
 import org.junit.Before;
 import org.junit.Test;
-import org.mockito.internal.util.reflection.Whitebox;
 import org.onap.policy.common.endpoints.http.server.RestServer;
 import org.onap.policy.common.endpoints.parameters.RestServerParameters;
 import org.onap.policy.common.endpoints.report.HealthCheckReport;
@@ -82,8 +81,7 @@ public class TestDistributionRestServer {
         port = NetworkUtil.allocPort();
         final String reportString =
                 "HealthCheckReport(name=Policy SSD, url=" + SELF + ", healthy=false, code=500, message=not alive)";
-        final RestServerParameters restServerParams = new CommonTestData().getRestServerParameters(false);
-        Whitebox.setInternalState(restServerParams, "port", port);
+        final RestServerParameters restServerParams = new CommonTestData().getRestServerParameters(port);
         restServerParams.setName(CommonTestData.DISTRIBUTION_GROUP_NAME);
         final RestServer restServer = new RestServer(restServerParams, null, DistributionRestController.class);
         restServer.start();
index 82e40cc..ecb49ce 100644 (file)
@@ -25,16 +25,16 @@ package org.onap.policy.distribution.main.rest;
 import static org.assertj.core.api.Assertions.assertThatCode;
 import static org.junit.Assert.assertEquals;
 
+import jakarta.ws.rs.client.Client;
+import jakarta.ws.rs.client.ClientBuilder;
+import jakarta.ws.rs.client.Invocation;
+import jakarta.ws.rs.client.WebTarget;
+import jakarta.ws.rs.core.MediaType;
 import java.io.IOException;
 import java.security.SecureRandom;
 import java.util.Properties;
 import javax.net.ssl.SSLContext;
 import javax.net.ssl.TrustManager;
-import javax.ws.rs.client.Client;
-import javax.ws.rs.client.ClientBuilder;
-import javax.ws.rs.client.Invocation;
-import javax.ws.rs.client.WebTarget;
-import javax.ws.rs.core.MediaType;
 import org.glassfish.jersey.client.authentication.HttpAuthenticationFeature;
 import org.junit.Before;
 import org.junit.Test;
index c9ca500..5aabde7 100644 (file)
 
 package org.onap.policy.distribution.forwarding.lifecycle.api;
 
+import jakarta.ws.rs.client.Entity;
+import jakarta.ws.rs.core.HttpHeaders;
+import jakarta.ws.rs.core.MediaType;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
-import javax.ws.rs.client.Entity;
-import javax.ws.rs.core.HttpHeaders;
-import javax.ws.rs.core.MediaType;
 import org.onap.policy.common.endpoints.http.client.HttpClient;
 import org.onap.policy.common.endpoints.http.client.HttpClientConfigException;
 import org.onap.policy.common.endpoints.http.client.HttpClientFactoryInstance;
index 9be6a0b..df2e36e 100644 (file)
 
 package org.onap.policy.distribution.forwarding.lifecycle.api;
 
+import jakarta.ws.rs.client.Entity;
+import jakarta.ws.rs.core.HttpHeaders;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
-import javax.ws.rs.client.Entity;
-import javax.ws.rs.core.HttpHeaders;
-import javax.ws.rs.core.MediaType;
-import javax.ws.rs.core.Response;
 import org.onap.policy.common.endpoints.http.client.HttpClient;
 import org.onap.policy.common.endpoints.http.client.HttpClientConfigException;
 import org.onap.policy.common.endpoints.http.client.HttpClientFactoryInstance;
index 00b017b..c50bf22 100644 (file)
 
 package org.onap.policy.distribution.forwarding.testclasses;
 
-import javax.ws.rs.Consumes;
-import javax.ws.rs.POST;
-import javax.ws.rs.Path;
-import javax.ws.rs.Produces;
-import javax.ws.rs.core.MediaType;
-import javax.ws.rs.core.Response;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
 import org.onap.policy.models.tosca.authorative.concepts.ToscaServiceTemplate;
 
 /**
index 22aeff2..810ac84 100644 (file)
 package org.onap.policy.distribution.forwarding.testclasses;
 
 import io.swagger.annotations.ApiParam;
-import javax.ws.rs.Consumes;
-import javax.ws.rs.POST;
-import javax.ws.rs.Path;
-import javax.ws.rs.PathParam;
-import javax.ws.rs.Produces;
-import javax.ws.rs.core.MediaType;
-import javax.ws.rs.core.Response;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
 import org.onap.policy.models.pap.concepts.PdpDeployPolicies;
 import org.onap.policy.models.pap.concepts.PdpGroupDeployResponse;
 import org.onap.policy.models.tosca.authorative.concepts.ToscaServiceTemplate;
index ac8a75d..279bb97 100644 (file)
@@ -30,8 +30,6 @@ import java.util.Collection;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
 import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.runners.MockitoJUnitRunner;
 import org.onap.policy.common.parameters.ParameterService;
 import org.onap.policy.distribution.model.Csar;
 import org.onap.policy.distribution.reception.decoding.PolicyDecodingException;
@@ -43,7 +41,6 @@ import org.onap.policy.models.tosca.authorative.concepts.ToscaEntity;
  *
  * @author Sirisha Manchikanti (sirisha.manchikanti@est.tech)
  */
-@RunWith(MockitoJUnitRunner.class)
 public class AutomationCompositionDecoderFileInCsarTest {
 
     /**
index 45dd167..640f472 100644 (file)
@@ -30,8 +30,6 @@ import java.util.Collection;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
 import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.runners.MockitoJUnitRunner;
 import org.onap.policy.common.parameters.ParameterService;
 import org.onap.policy.distribution.model.Csar;
 import org.onap.policy.distribution.reception.decoding.PolicyDecodingException;
@@ -43,7 +41,6 @@ import org.onap.policy.models.tosca.authorative.concepts.ToscaEntity;
  *
  * @author Ram Krishna Verma (ram.krishna.verma@ericsson.com)
  */
-@RunWith(MockitoJUnitRunner.class)
 public class PolicyDecoderFileInCsarToPolicyTest {
 
     /**
index 7308018..fcad382 100644 (file)
@@ -36,9 +36,7 @@ import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
-import org.junit.runner.RunWith;
 import org.mockito.Mockito;
-import org.mockito.runners.MockitoJUnitRunner;
 import org.mockito.stubbing.Answer;
 import org.onap.policy.common.parameters.ParameterService;
 import org.onap.policy.distribution.reception.statistics.DistributionStatisticsManager;
@@ -48,7 +46,6 @@ import org.slf4j.LoggerFactory;
 /**
  * Class to perform unit test of {@link FileSystemReceptionHandler}.
  */
-@RunWith(MockitoJUnitRunner.class)
 public class TestFileSystemReceptionHandler {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(TestFileSystemReceptionHandler.class);
@@ -160,4 +157,3 @@ public class TestFileSystemReceptionHandler {
 
     }
 }
-
index 3e8f4a6..9eaf67b 100644 (file)
@@ -26,7 +26,10 @@ import static org.assertj.core.api.Assertions.assertThatCode;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
-import static org.mockito.Matchers.any;
+import static  org.mockito.Mockito.any;
+import static  org.mockito.Mockito.mock;
+import static  org.mockito.Mockito.spy;
+import static  org.mockito.Mockito.when;
 
 import com.google.gson.Gson;
 import com.google.gson.GsonBuilder;
@@ -41,10 +44,6 @@ import java.util.Map;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.Mock;
-import org.mockito.Mockito;
-import org.mockito.runners.MockitoJUnitRunner;
 import org.onap.policy.common.parameters.ParameterService;
 import org.onap.policy.distribution.forwarding.PolicyForwarder;
 import org.onap.policy.distribution.forwarding.parameters.PolicyForwarderParameters;
@@ -68,23 +67,17 @@ import org.onap.sdc.utils.DistributionActionResultEnum;
  *
  * @author Ram Krishna Verma (ram.krishna.verma@ericsson.com)
  */
-@RunWith(MockitoJUnitRunner.class)
 public class TestSdcReceptionHandler {
 
     private static final String DUMMY_SERVICE_CSAR = "dummyService.csar";
 
-    @Mock
-    private IDistributionClientResult successfulClientInitResult;
-    @Mock
-    private IDistributionClientResult failureClientInitResult;
-    @Mock
-    private IDistributionClient distributionClient;
-    @Mock
-    private IDistributionClientDownloadResult successfulClientDownloadResult;
-    @Mock
-    private INotificationData notificationData;
-    @Mock
-    private IArtifactInfo artifactInfo;
+    private IDistributionClientResult successfulClientInitResult = mock(IDistributionClientResult.class);
+    private IDistributionClientResult failureClientInitResult = mock(IDistributionClientResult.class);
+    private IDistributionClient distributionClient = mock(IDistributionClient.class);
+    private IDistributionClientDownloadResult successfulClientDownloadResult
+        = mock(IDistributionClientDownloadResult.class);
+    private INotificationData notificationData = mock(INotificationData.class);
+    private IArtifactInfo artifactInfo = mock(IArtifactInfo.class);
 
     private SdcReceptionHandlerConfigurationParameterGroup pssdConfigParameters;
     private SdcReceptionHandler sypHandler;
@@ -105,27 +98,27 @@ public class TestSdcReceptionHandler {
             SdcReceptionHandlerConfigurationParameterGroup.class);
         ParameterService.register(pssdConfigParameters);
         final SdcReceptionHandler sdcHandler = new SdcReceptionHandler();
-        sypHandler = Mockito.spy(sdcHandler);
-
-        Mockito.when(sypHandler.createSdcDistributionClient()).thenReturn(distributionClient);
-        Mockito.when(distributionClient.init(any(), any())).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.start()).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.stop()).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.sendComponentDoneStatus(any())).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.sendComponentDoneStatus(any(), any())).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.sendDownloadStatus(any())).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.sendDownloadStatus(any(), any())).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.sendDeploymentStatus(any())).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.sendDeploymentStatus(any(), any())).thenReturn(successfulClientInitResult);
-        Mockito.when(distributionClient.download(any())).thenReturn(successfulClientDownloadResult);
-        Mockito.when(notificationData.getServiceArtifacts()).thenReturn(List.of(artifactInfo));
-        Mockito.when(artifactInfo.getArtifactName()).thenReturn(DUMMY_SERVICE_CSAR);
-        Mockito.when(successfulClientDownloadResult.getArtifactPayload()).thenReturn(new byte[1]);
-        Mockito.when(successfulClientInitResult.getDistributionActionResult())
+        sypHandler = spy(sdcHandler);
+
+        when(sypHandler.createSdcDistributionClient()).thenReturn(distributionClient);
+        when(distributionClient.init(any(), any())).thenReturn(successfulClientInitResult);
+        when(distributionClient.start()).thenReturn(successfulClientInitResult);
+        when(distributionClient.stop()).thenReturn(successfulClientInitResult);
+        when(distributionClient.sendComponentDoneStatus(any())).thenReturn(successfulClientInitResult);
+        when(distributionClient.sendComponentDoneStatus(any(), any())).thenReturn(successfulClientInitResult);
+        when(distributionClient.sendDownloadStatus(any())).thenReturn(successfulClientInitResult);
+        when(distributionClient.sendDownloadStatus(any(), any())).thenReturn(successfulClientInitResult);
+        when(distributionClient.sendDeploymentStatus(any())).thenReturn(successfulClientInitResult);
+        when(distributionClient.sendDeploymentStatus(any(), any())).thenReturn(successfulClientInitResult);
+        when(distributionClient.download(any())).thenReturn(successfulClientDownloadResult);
+        when(notificationData.getServiceArtifacts()).thenReturn(List.of(artifactInfo));
+        when(artifactInfo.getArtifactName()).thenReturn(DUMMY_SERVICE_CSAR);
+        when(successfulClientDownloadResult.getArtifactPayload()).thenReturn(new byte[1]);
+        when(successfulClientInitResult.getDistributionActionResult())
             .thenReturn(DistributionActionResultEnum.SUCCESS);
-        Mockito.when(successfulClientDownloadResult.getDistributionActionResult())
+        when(successfulClientDownloadResult.getDistributionActionResult())
             .thenReturn(DistributionActionResultEnum.SUCCESS);
-        Mockito.when(failureClientInitResult.getDistributionActionResult())
+        when(failureClientInitResult.getDistributionActionResult())
             .thenReturn(DistributionActionResultEnum.FAIL);
 
     }
@@ -144,7 +137,7 @@ public class TestSdcReceptionHandler {
     @Test
     public final void testInitializeSdcClient_Failure() {
 
-        Mockito.when(successfulClientInitResult.getDistributionActionResult())
+        when(successfulClientInitResult.getDistributionActionResult())
             .thenReturn(DistributionActionResultEnum.FAIL).thenReturn(DistributionActionResultEnum.SUCCESS);
         assertThatCode(() -> sypHandler.initializeReception(pssdConfigParameters.getName()))
             .doesNotThrowAnyException();
@@ -153,7 +146,7 @@ public class TestSdcReceptionHandler {
     @Test
     public final void testStartSdcClient_Failure() {
         assertThatCode(() -> {
-            Mockito.when(distributionClient.start()).thenReturn(failureClientInitResult)
+            when(distributionClient.start()).thenReturn(failureClientInitResult)
                 .thenReturn(successfulClientInitResult);
             sypHandler.initializeReception(pssdConfigParameters.getName());
         }).doesNotThrowAnyException();
@@ -170,7 +163,7 @@ public class TestSdcReceptionHandler {
     @Test
     public final void testStopSdcClient_Failure() {
         sypHandler.initializeReception(pssdConfigParameters.getName());
-        Mockito.when(distributionClient.stop()).thenReturn(failureClientInitResult)
+        when(distributionClient.stop()).thenReturn(failureClientInitResult)
             .thenReturn(successfulClientInitResult);
         assertThatCode(() -> sypHandler.destroy()).doesNotThrowAnyException();
     }
@@ -211,7 +204,7 @@ public class TestSdcReceptionHandler {
     public void testDownloadArtifactFailure() throws NoSuchFieldException, SecurityException, IllegalArgumentException,
         IllegalAccessException, PluginInitializationException {
 
-        Mockito.when(successfulClientDownloadResult.getDistributionActionResult())
+        when(successfulClientDownloadResult.getDistributionActionResult())
             .thenReturn(DistributionActionResultEnum.FAIL);
 
         final DummyDecoder policyDecoder = new DummyDecoder();
@@ -240,11 +233,11 @@ public class TestSdcReceptionHandler {
     public void testSendDistributionStatusFailure() throws NoSuchFieldException, SecurityException,
         IllegalArgumentException, IllegalAccessException, PluginInitializationException {
 
-        Mockito.when(successfulClientDownloadResult.getDistributionActionResult())
+        when(successfulClientDownloadResult.getDistributionActionResult())
             .thenReturn(DistributionActionResultEnum.FAIL);
-        Mockito.when(distributionClient.sendDownloadStatus(any(), any())).thenReturn(failureClientInitResult);
-        Mockito.when(distributionClient.sendDeploymentStatus(any(), any())).thenReturn(failureClientInitResult);
-        Mockito.when(distributionClient.sendComponentDoneStatus(any(), any())).thenReturn(failureClientInitResult);
+        when(distributionClient.sendDownloadStatus(any(), any())).thenReturn(failureClientInitResult);
+        when(distributionClient.sendDeploymentStatus(any(), any())).thenReturn(failureClientInitResult);
+        when(distributionClient.sendComponentDoneStatus(any(), any())).thenReturn(failureClientInitResult);
 
         final DummyDecoder policyDecoder = new DummyDecoder();
         final Collection<PolicyDecoder<Csar, DummyPolicy>> policyDecoders = new ArrayList<>();
diff --git a/pom.xml b/pom.xml
index 6f7a2c3..b023a2f 100644 (file)
--- a/pom.xml
+++ b/pom.xml
@@ -47,6 +47,9 @@
 
         <policy.common.version>2.0.0-SNAPSHOT</policy.common.version>
         <policy.models.version>3.0.0-SNAPSHOT</policy.models.version>
+        <surefireArgLine>
+            --add-opens java.base/java.lang=ALL-UNNAMED
+        </surefireArgLine>
     </properties>
 
     <modules>
@@ -72,7 +75,7 @@
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
-            <artifactId>mockito-all</artifactId>
+            <artifactId>mockito-core</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>