Re-enable formatting and fix formatting issues 76/129276/1
authorJozsef Csongvai <jozsef.csongvai@bell.ca>
Mon, 16 May 2022 15:03:43 +0000 (11:03 -0400)
committerJozsef Csongvai <jozsef.csongvai@bell.ca>
Mon, 16 May 2022 15:03:43 +0000 (11:03 -0400)
Issue-ID: CCSDK-3657
Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca>
Change-Id: Idd1871e82a319325b042c339741a66c06499692c

18 files changed:
ms/blueprintsprocessor/functions/k8s-connection-plugin/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/k8s/definition/K8sPluginDefinitionApi.kt
ms/blueprintsprocessor/functions/k8s-connection-plugin/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/k8s/definition/profile/K8sProfileUploadComponent.kt
ms/blueprintsprocessor/functions/k8s-connection-plugin/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/k8s/instance/K8sPluginInstanceApi.kt
ms/blueprintsprocessor/functions/k8s-connection-plugin/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/k8s/query/K8sPluginQueryApi.kt
ms/blueprintsprocessor/functions/k8s-connection-plugin/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/k8s/query/K8sQueryRestClient.kt
ms/blueprintsprocessor/functions/k8s-connection-plugin/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/k8s/query/K8sResourceStatus.kt
ms/blueprintsprocessor/functions/resource-resolution/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/resource/resolution/ResourceResolutionExtensions.kt
ms/blueprintsprocessor/functions/resource-resolution/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/resource/resolution/ResourceResolutionService.kt
ms/blueprintsprocessor/functions/resource-resolution/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/resource/resolution/db/ResourceResolution.kt
ms/blueprintsprocessor/functions/resource-resolution/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/resource/resolution/db/TemplateResolution.kt
ms/blueprintsprocessor/functions/resource-resolution/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/resource/resolution/db/TemplateResolutionSelector.kt
ms/blueprintsprocessor/functions/resource-resolution/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/functions/resource/resolution/db/TemplateResolutionService.kt
ms/blueprintsprocessor/modules/blueprints/blueprint-core/src/main/kotlin/org/onap/ccsdk/cds/controllerblueprints/core/BluePrintError.kt
ms/blueprintsprocessor/modules/commons/message-lib/src/main/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/message/BluePrintMessageLibData.kt
ms/blueprintsprocessor/modules/commons/message-lib/src/test/kotlin/org/onap/ccsdk/cds/blueprintsprocessor/message/service/BlueprintMessageConsumerServiceTest.kt
ms/sdclistener/application/src/main/java/org/onap/ccsdk/cds/sdclistener/service/ListenerServiceImpl.java
ms/sdclistener/application/src/test/java/org/onap/ccsdk/cds/sdclistener/service/ListenerServiceImplTest.java
pom.xml

index 02b2556..ed0b164 100644 (file)
@@ -24,7 +24,6 @@ import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.definition.profile.K
 import com.fasterxml.jackson.module.kotlin.readValue
 import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.K8sConnectionPluginConfiguration
 import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.definition.template.K8sTemplate
-import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.instance.K8sRbInstanceFull
 import org.onap.ccsdk.cds.blueprintsprocessor.rest.service.BlueprintWebClientService
 import org.onap.ccsdk.cds.controllerblueprints.core.BluePrintProcessorException
 import org.onap.ccsdk.cds.controllerblueprints.core.utils.JacksonUtils
@@ -156,7 +155,7 @@ class K8sPluginDefinitionApi(
         try {
             val result: BlueprintWebClientService.WebClientResponse<String> = rbDefinitionService.exchangeResource(
                 DELETE.name,
-                "/profile/${profileName}",
+                "/profile/$profileName",
                 ""
             )
             log.debug(result.toString())
index e7d781d..443233b 100644 (file)
@@ -29,7 +29,6 @@ import org.onap.ccsdk.cds.blueprintsprocessor.core.BluePrintPropertiesService
 import org.onap.ccsdk.cds.blueprintsprocessor.core.api.data.ExecutionServiceInput
 import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.K8sConnectionPluginConfiguration
 import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.definition.K8sPluginDefinitionApi
-import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.instance.K8sRbInstance
 import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.instance.K8sRbInstanceGvk
 import org.onap.ccsdk.cds.controllerblueprints.resource.dict.ResourceAssignment
 import org.onap.ccsdk.cds.blueprintsprocessor.functions.resource.resolution.ResourceResolutionConstants
index 1be45e8..a991795 100644 (file)
@@ -303,7 +303,7 @@ class K8sPluginInstanceApi(
         }
     }
 
-    fun editConfigurationValuesByDelete(instanceId: String, configName: String): K8sConfigValueResponse?  {
+    fun editConfigurationValuesByDelete(instanceId: String, configName: String): K8sConfigValueResponse? {
         val rbInstanceService = K8sRbInstanceRestClient(k8sConfiguration, instanceId)
         try {
             val result: BlueprintWebClientService.WebClientResponse<String> = rbInstanceService.exchangeResource(
@@ -450,9 +450,9 @@ class K8sPluginInstanceApi(
         val rbInstanceService = K8sRbInstanceRestClient(k8sConfiguration, instanceId)
         try {
             val result: BlueprintWebClientService.WebClientResponse<String> = rbInstanceService.exchangeResource(
-                    GET.name,
-                    "/config/$configName/version",
-                    ""
+                GET.name,
+                "/config/$configName/version",
+                ""
             )
             log.debug(result.toString())
             return if (result.status in 200..299) {
index 9a5051f..36ebe11 100644 (file)
@@ -1,4 +1,4 @@
-package org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.query;
+package org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.query
 
 import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.K8sConnectionPluginConfiguration
 import org.onap.ccsdk.cds.blueprintsprocessor.rest.service.BlueprintWebClientService
@@ -8,17 +8,17 @@ import org.slf4j.LoggerFactory
 import org.springframework.http.HttpMethod.GET
 
 public class K8sPluginQueryApi(
-        private val k8sConfiguration: K8sConnectionPluginConfiguration
+    private val k8sConfiguration: K8sConnectionPluginConfiguration
 ) {
     private val log = LoggerFactory.getLogger(K8sPluginQueryApi::class.java)!!
 
     fun queryK8sResources(
-            cloudRegion: String,
-            kind: String,
-            apiVersion: String,
-            name: String? = null,
-            namespace: String? = null,
-            labels: Map<String, String>? = null
+        cloudRegion: String,
+        kind: String,
+        apiVersion: String,
+        name: String? = null,
+        namespace: String? = null,
+        labels: Map<String, String>? = null
     ): K8sResourceStatus? {
         val rbQueryService = K8sQueryRestClient(k8sConfiguration)
         try {
@@ -34,14 +34,14 @@ public class K8sPluginQueryApi(
                 path = path.trimEnd(',')
             }
             val result: BlueprintWebClientService.WebClientResponse<String> = rbQueryService.exchangeResource(
-                    GET.name,
-                    path,
-                    ""
+                GET.name,
+                path,
+                ""
             )
             log.debug(result.toString())
             return if (result.status in 200..299) {
                 val parsedObject: K8sResourceStatus? = JacksonUtils.readValue(
-                        result.body, K8sResourceStatus::class.java
+                    result.body, K8sResourceStatus::class.java
                 )
                 parsedObject
             } else if (result.status == 500 && result.body.contains("Error finding master table"))
index dda5a6e..672a366 100644 (file)
@@ -22,7 +22,7 @@ import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.K8sAbstractRestClien
 import org.onap.ccsdk.cds.blueprintsprocessor.functions.k8s.K8sConnectionPluginConfiguration
 
 open class K8sQueryRestClient(
-        k8sConfiguration: K8sConnectionPluginConfiguration
+    k8sConfiguration: K8sConnectionPluginConfiguration
 ) : K8sAbstractRestClientService(k8sConfiguration) {
 
     override fun apiUrl(): String {
index f7d41bc..38c5baa 100644 (file)
@@ -46,7 +46,7 @@ suspend fun AbstractComponentFunction.storedResolutionKeysForArtifactNameNB(
         .resolveResolutionKeysFromDatabase(bluePrintRuntimeService, artifactName)
 }
 
-suspend fun AbstractComponentFunction.storedArtifactNamesAndResolutionKeysNB(): Map<String,List<String>> {
+suspend fun AbstractComponentFunction.storedArtifactNamesAndResolutionKeysNB(): Map<String, List<String>> {
     return BluePrintDependencyService.resourceResolutionService()
         .resolveArtifactNamesAndResolutionKeysFromDatabase(bluePrintRuntimeService)
 }
@@ -84,5 +84,5 @@ fun AbstractComponentFunction.storedContentFromResolvedArtifact(resolutionKey: S
     }
 
 fun AbstractComponentFunction.contentFromResolvedArtifact(artifactPrefix: String): String = runBlocking {
-        contentFromResolvedArtifactNB(artifactPrefix)
-    }
\ No newline at end of file
+    contentFromResolvedArtifactNB(artifactPrefix)
+}
index 2352c7d..df07b8e 100644 (file)
@@ -145,7 +145,8 @@ open class ResourceResolutionServiceImpl(
     }
 
     override suspend fun resolveArtifactNamesAndResolutionKeysFromDatabase(
-        bluePrintRuntimeService: BluePrintRuntimeService<*>): Map<String, List<String>> {
+        bluePrintRuntimeService: BluePrintRuntimeService<*>
+    ): Map<String, List<String>> {
         return templateResolutionDBService.findArtifactNamesAndResolutionKeysByBlueprintNameAndBlueprintVersion(
             bluePrintRuntimeService
         )
@@ -498,4 +499,4 @@ open class ResourceResolutionServiceImpl(
             properties[ResourceResolutionConstants.RESOURCE_RESOLUTION_INPUT_OCCURRENCE].asJsonPrimitive()
         )
     }
-}
\ No newline at end of file
+}
index 40a447d..8b0f75c 100644 (file)
@@ -35,13 +35,16 @@ import javax.persistence.TemporalType
 
 @EntityListeners(AuditingEntityListener::class)
 @Entity
-@Table(name = "RESOURCE_RESOLUTION",
-indexes = [Index(name = "idx_rr_bpnameversion", columnList = "blueprint_name, blueprint_version"),
-    Index(name = "idx_rr_resolution_key", columnList = "resolution_key"),
-    Index(name = "idx_rr_name", columnList = "name"),
-    Index(name = "idx_rr_artifact_name", columnList = "artifact_name"),
-    Index(name = "idx_rr_resource_idtype", columnList = "resource_id, resource_type")
-])
+@Table(
+    name = "RESOURCE_RESOLUTION",
+    indexes = [
+        Index(name = "idx_rr_bpnameversion", columnList = "blueprint_name, blueprint_version"),
+        Index(name = "idx_rr_resolution_key", columnList = "resolution_key"),
+        Index(name = "idx_rr_name", columnList = "name"),
+        Index(name = "idx_rr_artifact_name", columnList = "artifact_name"),
+        Index(name = "idx_rr_resource_idtype", columnList = "resource_id, resource_type")
+    ]
+)
 @Proxy(lazy = false)
 class ResourceResolution : Serializable {
 
index 46e0d45..6a7a2cd 100755 (executable)
@@ -35,12 +35,15 @@ import javax.persistence.TemporalType
 
 @EntityListeners(AuditingEntityListener::class)
 @Entity
-@Table(name = "TEMPLATE_RESOLUTION", indexes = [
-    Index(name = "idx_tr_bpnameversion", columnList = "blueprint_name, blueprint_version"),
-    Index(name = "idx_tr_resource_idtype", columnList = "resource_id, resource_type"),
-    Index(name = "idx_tr_artifact_name", columnList = "artifact_name"),
-    Index(name = "idx_tr_resolution_key", columnList = "resolution_key")
-])
+@Table(
+    name = "TEMPLATE_RESOLUTION",
+    indexes = [
+        Index(name = "idx_tr_bpnameversion", columnList = "blueprint_name, blueprint_version"),
+        Index(name = "idx_tr_resource_idtype", columnList = "resource_id, resource_type"),
+        Index(name = "idx_tr_artifact_name", columnList = "artifact_name"),
+        Index(name = "idx_tr_resolution_key", columnList = "resolution_key")
+    ]
+)
 @Proxy(lazy = false)
 class TemplateResolution : Serializable {
 
index fd4cc8c..8789ade 100644 (file)
@@ -93,7 +93,7 @@ class TemplateResolutionService(private val templateResolutionRepository: Templa
     suspend fun findArtifactNamesAndResolutionKeysByBlueprintNameAndBlueprintVersion(
         bluePrintRuntimeService: BluePrintRuntimeService<*>,
         occurrence: Int = 1
-    ): Map<String,List<String>> =
+    ): Map<String, List<String>> =
         withContext(Dispatchers.IO) {
 
             val metadata = bluePrintRuntimeService.bluePrintContext().metadata!!
@@ -241,4 +241,4 @@ class TemplateResolutionService(private val templateResolutionRepository: Templa
                 throw BluePrintException("Failed to store resource api result.", ex)
             }
         }
-}
\ No newline at end of file
+}
index 886c87c..e0e073d 100644 (file)
@@ -130,8 +130,8 @@ class KafkaScramPlainTextAuthMessageProducerProperties : KafkaBasicAuthMessagePr
         configProps[CommonClientConfigs.SECURITY_PROTOCOL_CONFIG] = SecurityProtocol.SASL_PLAINTEXT.toString()
         configProps[SaslConfigs.SASL_MECHANISM] = saslMechanism
         configProps[SaslConfigs.SASL_JAAS_CONFIG] = "${ScramLoginModule::class.java.canonicalName} required " +
-                "username=\"${scramUsername}\" " +
-                "password=\"${scramPassword}\";"
+            "username=\"${scramUsername}\" " +
+            "password=\"${scramPassword}\";"
         return configProps
     }
 }
@@ -297,8 +297,8 @@ class KafkaScramPlaintextAuthMessageConsumerProperties : KafkaBasicAuthMessageCo
         configProps[CommonClientConfigs.SECURITY_PROTOCOL_CONFIG] = SecurityProtocol.SASL_PLAINTEXT.toString()
         configProps[SaslConfigs.SASL_MECHANISM] = saslMechanism
         configProps[SaslConfigs.SASL_JAAS_CONFIG] = "${ScramLoginModule::class.java.canonicalName} required " +
-                "username=\"${scramUsername}\" " +
-                "password=\"${scramPassword}\";"
+            "username=\"${scramUsername}\" " +
+            "password=\"${scramPassword}\";"
         return configProps
     }
 }
index dd81d76..ee27a94 100644 (file)
@@ -81,7 +81,8 @@ public class ListenerServiceImpl implements ListenerService {
     @Value("${listenerservice.config.grpcPort}")
     private int grpcPort;
 
-    private static final String CBA_ZIP_PATH = "Artifacts/[a-zA-Z0-9-_.]+/Deployment/CONTROLLER_BLUEPRINT_ARCHIVE/[a-zA-Z0-9-_.()]+[.]zip";
+    private static final String CBA_ZIP_PATH =
+            "Artifacts/[a-zA-Z0-9-_.]+/Deployment/CONTROLLER_BLUEPRINT_ARCHIVE/[a-zA-Z0-9-_.()]+[.]zip";
     private static final int SUCCESS_CODE = 200;
     private static final Logger LOGGER = LoggerFactory.getLogger(ListenerServiceImpl.class);
 
index dcf942f..6ea326b 100644 (file)
@@ -50,14 +50,15 @@ import static org.onap.ccsdk.cds.sdclistener.status.SdcListenerStatus.Notificati
 import static org.onap.sdc.utils.DistributionStatusEnum.COMPONENT_DONE_OK;
 
 @RunWith(SpringRunner.class)
-@EnableConfigurationProperties({ SdcListenerAuthClientInterceptor.class, BluePrintProcesssorHandler.class,
-        SdcListenerDto.class, ListenerServiceImpl.class, SdcListenerStatus.class, SdcListenerConfiguration.class })
-@SpringBootTest(classes = { ListenerServiceImplTest.class })
+@EnableConfigurationProperties({SdcListenerAuthClientInterceptor.class, BluePrintProcesssorHandler.class,
+        SdcListenerDto.class, ListenerServiceImpl.class, SdcListenerStatus.class, SdcListenerConfiguration.class})
+@SpringBootTest(classes = {ListenerServiceImplTest.class})
 public class ListenerServiceImplTest {
 
     private static final String CSAR_SAMPLE = "src/test/resources/service-ServicePnfTest-csar.csar";
     private static final String WRONG_CSAR_SAMPLE = "src/test/resources/wrong_csar_pattern.csar";
-    private static final String CBA_ZIP_PATH = "Artifacts/[a-zA-Z0-9-_.]+/Deployment/CONTROLLER_BLUEPRINT_ARCHIVE/[a-zA-Z0-9-_.()]+[.]zip";
+    private static final String CBA_ZIP_PATH =
+            "Artifacts/[a-zA-Z0-9-_.]+/Deployment/CONTROLLER_BLUEPRINT_ARCHIVE/[a-zA-Z0-9-_.()]+[.]zip";
     private static final String ZIP_FILE = ".zip";
     private static final String CSAR_FILE = ".csar";
     private static final String DISTRIBUTION_ID = "1";
@@ -152,8 +153,7 @@ public class ListenerServiceImplTest {
             return "Stub Result, method not implemented!";
         }
 
-        public DistributionClientDownloadResultStubImpl() {
-        }
+        public DistributionClientDownloadResultStubImpl() {}
 
         public byte[] getArtifactPayload() {
             File file = Paths.get(CSAR_SAMPLE).toFile();
diff --git a/pom.xml b/pom.xml
index 56ebbe0..10f4268 100644 (file)
--- a/pom.xml
+++ b/pom.xml
@@ -58,7 +58,7 @@ limitations under the License.
         <jacoco.version>0.8.3</jacoco.version>
 
         <!-- Properties for POM Format -->
-        <format.skipValidate>true</format.skipValidate>
+        <format.skipValidate>false</format.skipValidate>
         <format.skipExecute>true</format.skipExecute>
 
         <java.version>11</java.version>