Merge this if statement with the enclosing one 75/98275/1
authoranushadasari <danush10@in.ibm.com>
Tue, 12 Nov 2019 07:09:52 +0000 (12:39 +0530)
committeranushadasari <danush10@in.ibm.com>
Tue, 12 Nov 2019 07:10:01 +0000 (12:40 +0530)
Merging collapsible if statements increases the code's readability.

Issue-ID: OPTFRA-634
Change-Id: Ib1a5e730820b832f5e1d42aefd75f925a2ad26cc
Signed-off-by: anushadasari <danush10@in.ibm.com>
cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafAuthProvider.java

index 96f2ef2..80accfe 100755 (executable)
@@ -66,10 +66,8 @@ public class AafAuthProvider implements AuthenticationProvider {
                 sessionId = webAuthDetails.getRemoteAddress() + ":" + webAuthDetails.getSessionId();\r
             }\r
         }\r
-        if (env.getProperty(AafProperties.aafEnabled.toString(), Boolean.class, true)) {\r
-            if (clientCache.authenticate(name, password, sessionId) != AuthorizationResult.Authenticated) {\r
+        if ((env.getProperty(AafProperties.aafEnabled.toString(), Boolean.class, true)) && (clientCache.authenticate(name, password, sessionId) != AuthorizationResult.Authenticated)) {\r
                 return null;\r
-            }\r
         }\r
         return new UsernamePasswordAuthenticationToken(name, password, new ArrayList<>());\r
 \r