added test cases to ExternalAccessRoleTest

to increase code coverage

Issue-ID: PORTAL-273
Change-Id: I52c4aedc7d9ecc1d1fb53d58731efaa32fbcbaa1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>

diff --git a/ecomp-sdk/epsdk-aaf/src/test/java/org/onap/portalsdk/external/authorization/domain/ExternalAccessRoleTest.java b/ecomp-sdk/epsdk-aaf/src/test/java/org/onap/portalsdk/external/authorization/domain/ExternalAccessRoleTest.java
index 3fc5ae8..557f544 100644 (file)
--- a/ecomp-sdk/epsdk-aaf/src/test/java/org/onap/portalsdk/external/authorization/domain/ExternalAccessRoleTest.java
+++ b/ecomp-sdk/epsdk-aaf/src/test/java/org/onap/portalsdk/external/authorization/domain/ExternalAccessRoleTest.java
@@ -4,6 +4,8 @@
  * ===================================================================
  * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
  * ===================================================================
+ * Modifications Copyright (C) 2018 IBM.
+ * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
  * under the Apache License, Version 2.0 (the "License");
@@ -38,37 +40,62 @@
 package org.onap.portalsdk.external.authorization.domain;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
 import java.util.ArrayList;
 import java.util.List;
 
+import org.junit.Before;
 import org.junit.Test;
 
 public class ExternalAccessRoleTest {
+    
+    private ExternalAccessRole mockRole;
+    private ExternalAccessRole role;
+    private ExternalAccessRole role1;
 
-       public ExternalAccessRole mockExternalAccessRoleTest() {
-               ExternalAccessRole mockRole = new ExternalAccessRole();
-               ExternalAccessRoleDescription roleDesc =  new ExternalAccessRoleDescription();
-               ExternalAccessPerms ecPerm =  new ExternalAccessPerms();
-               List<ExternalAccessPerms> ecPerms = new ArrayList<>();
-               ecPerm.setAction("test_action");
-               ecPerm.setType("test_type");
-               ecPerm.setInstance("test_instance");
-               ecPerm.setDescription("test_description");
-               roleDesc.setActive("true");
-               roleDesc.setAppId("1");
-               mockRole.setName("test_role");
-               mockRole.setPerms(ecPerms);
-               mockRole.setDescription(roleDesc);
-               return mockRole;
-       }
+    public ExternalAccessRole mockExternalAccessRoleTest() {
+        ExternalAccessRole mockRole = new ExternalAccessRole();
+        ExternalAccessRoleDescription roleDesc =  new ExternalAccessRoleDescription();
+        ExternalAccessPerms ecPerm =  new ExternalAccessPerms();
+        List<ExternalAccessPerms> ecPerms = new ArrayList<>();
+        ecPerm.setAction("test_action");
+        ecPerm.setType("test_type");
+        ecPerm.setInstance("test_instance");
+        ecPerm.setDescription("test_description");
+        roleDesc.setActive("true");
+        roleDesc.setAppId("1");
+        mockRole.setName("test_role");
+        mockRole.setPerms(ecPerms);
+        mockRole.setDescription(roleDesc);
+        return mockRole;
+    }
+    
+    @Before
+    public void setUp()
+    {
+        mockRole = mockExternalAccessRoleTest();
+        role = new ExternalAccessRole(mockRole.getName(), mockRole.getPerms(), mockRole.getDescription());
+        role1= new ExternalAccessRole(mockRole.getName(), mockRole.getPerms(), mockRole.getDescription());;
+    }
 
-       @Test
-       public void externalAccessRolePermsTest() {
-               ExternalAccessRole mockRole = mockExternalAccessRoleTest();
-               ExternalAccessRole role = new ExternalAccessRole(mockRole.getName(), mockRole.getPerms(), mockRole.getDescription());
-               assertEquals(role.getName(), mockExternalAccessRoleTest().getName());
-               assertEquals(role.getPerms(), mockExternalAccessRoleTest().getPerms());
-               assertEquals(role.getDescription(), mockExternalAccessRoleTest().getDescription());
-       }
+    @Test
+    public void externalAccessRolePermsTest() {
+        
+        assertEquals(role.getName(), mockExternalAccessRoleTest().getName());
+        assertEquals(role.getPerms(), mockExternalAccessRoleTest().getPerms());
+        assertEquals(role.getDescription(), mockExternalAccessRoleTest().getDescription());
+    }
+    
+    @Test
+    public void testEquals() {
+        
+        assertTrue(role.equals(role1));
+        }
+    
+    @Test
+    public void testHashCode () {
+        assertTrue((Integer)role.hashCode() instanceof Integer);
+        
+    }
 }