Move "*" string literal on left side of string 59/98659/1
authoranushadasari <danush10@in.ibm.com>
Wed, 20 Nov 2019 11:13:57 +0000 (16:43 +0530)
committeranushadasari <danush10@in.ibm.com>
Wed, 20 Nov 2019 11:14:06 +0000 (16:44 +0530)
It is preferable to place string literals on the left-hand side of an equals() or equalsIgnoreCase() method call.

Issue-ID: OPTFRA-647
Change-Id: Ibd04d10da4e655be44310ec0459f1fdeab791441
Signed-off-by: anushadasari <danush10@in.ibm.com>
cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java

index d324f18..b8e7f5b 100755 (executable)
@@ -90,9 +90,9 @@ public class AafPerm {
      */\r
     public boolean ok(AafPerm userPerm) {\r
         if (type.equals(userPerm.getType())) {\r
-            if (userPerm.getInstance().equals("*") || instance.equals("*") || userPerm.getInstance().equals(instance)) {\r
+            if ("*".equals(userPerm.getInstance()) || "*".equals(instance) || userPerm.getInstance().equals(instance)) {\r
                 for (String userAction : userPerm.getActions()) {\r
-                    if (userAction.equals("*") || actions.contains("*") || actions.contains(userAction)) {\r
+                    if ("*".equals(userAction) || actions.contains("*") || actions.contains(userAction)) {\r
                         return true;\r
                     }\r
                 }\r