Merge this if statement with the enclosing one 58/98658/1
authoranushadasari <danush10@in.ibm.com>
Wed, 20 Nov 2019 11:07:35 +0000 (16:37 +0530)
committeranushadasari <danush10@in.ibm.com>
Wed, 20 Nov 2019 11:07:43 +0000 (16:37 +0530)
Merging collapsible if statements increases the code's readability.

Issue-ID: OPTFRA-634
Change-Id: I22d3bd915605507db8fbfcae9d52a5b1b2de8f3f
Signed-off-by: anushadasari <danush10@in.ibm.com>
cmso-service/src/main/java/org/onap/optf/cmso/filters/CmsoClientFilters.java

index 893d74c..804fe68 100644 (file)
@@ -72,10 +72,8 @@ public class CmsoClientFilters implements ClientRequestFilter, ClientResponseFil
 
         String transactionId = (String) headers.getFirst(MessageHeaders.HeadersEnum.TransactionID.toString());
         String mdcId = MDC.get(MDC_KEY_REQUEST_ID);
-        if (transactionId == null || "".equals(transactionId)) {
-            if (mdcId != null) {
+        if ((transactionId == null || "".equals(transactionId)) && (mdcId != null)) {
                 headers.add(HeadersEnum.TransactionID.toString(), mdcId);
-            }
         }
         headers.add(HeadersEnum.FromAppID.toString(), appId);
     }