Used isEmpty to check collection is empty or not

Issue-ID: DCAEGEN2-1468

Signed-off-by: Rama-Huawei <rama.subba.reddy.s@huawei.com>
Change-Id: Ice0fe7a0119442f7cf7f6171ea1e2a2c8a0c8cab

diff --git a/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/DesignService.java b/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/DesignService.java
index d0940ba..d492497 100755 (executable)
--- a/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/DesignService.java
+++ b/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/DesignService.java
@@ -114,7 +114,7 @@ public class DesignService {
                                        dbs.add(db.get());\r
                                }\r
                        }\r
-                       if (dbs.size() > 0)\r
+                       if (!dbs.isEmpty())\r
                                design.setDbs(dbs);\r
                        else {\r
                                design.getDbs().clear();\r

diff --git a/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/DesignTypeService.java b/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/DesignTypeService.java
index 86baebf..58bc35e 100755 (executable)
--- a/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/DesignTypeService.java
+++ b/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/DesignTypeService.java
@@ -49,7 +49,7 @@ public class DesignTypeService {
                List<DesignType> designTypeList = null;\r
                List<DesignTypeConfig> designTypeConfigList = new ArrayList<>();\r
                designTypeList = (List<DesignType>)designTypeRepository.findAll();\r
-               if (designTypeList != null && designTypeList.size() > 0) {\r
+               if (designTypeList != null && !designTypeList.isEmpty()) {\r
                        log.info("DesignTypeList is not null");\r
                        for(DesignType designType : designTypeList) {\r
                                designTypeConfigList.add(designType.getDesignTypeConfig());\r

diff --git a/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/TopicService.java b/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/TopicService.java
index ed9b5c2..043cc65 100644 (file)
--- a/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/TopicService.java
+++ b/components/datalake-handler/feeder/src/main/java/org/onap/datalake/feeder/service/TopicService.java
@@ -162,9 +162,9 @@ public class TopicService {
                                        relateDb.add(sinkdb);
                                }
                        }
-                       if (relateDb.size() > 0)
+                       if (!relateDb.isEmpty())
                                topic.setDbs(relateDb);
-                       else if (relateDb.size() == 0) {
+                       else {
                                topic.getDbs().clear();
                        }
                } else {
@@ -179,9 +179,9 @@ public class TopicService {
                                        relateKafka.add(sinkKafka.get());
                                }
                        }
-                       if (relateKafka.size() > 0) {
+                       if (!relateKafka.isEmpty()) {
                                topic.setKafkas(relateKafka);
-                       } else if (relateKafka.size() == 0) {
+                       } else {
                                topic.getKafkas().clear();
                        }
                } else {