TicketEventServiceImpl : Fixed sonar issue

Fixed below sonar issue at line 52,
Immediately return this expression instead of assigning it to the
temporary variable 'hyperlink'

Issue-ID: PORTAL-364
Change-Id: I33b854b15e163146415040bf98dbd7e992d04b61
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>

diff --git a/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/TicketEventServiceImpl.java b/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/TicketEventServiceImpl.java
index 5dba0b2..71c2b1e 100644 (file)
--- a/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/TicketEventServiceImpl.java
+++ b/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/TicketEventServiceImpl.java
@@ -3,6 +3,8 @@
  * ONAP Portal
  * ===================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * 
+ * Modifications Copyright (C) 2018 IBM.
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
@@ -49,8 +51,6 @@ public class TicketEventServiceImpl implements TicketEventService{
 
        @Override
        public String getNotificationHyperLink(JsonNode application, String ticket, String eventSource) {
-               String hyperlink = SystemProperties.getProperty(EPCommonSystemProperties.EXTERNAL_SYSTEM_NOTIFICATION_URL)+ticket;
-               return hyperlink;
+               return (SystemProperties.getProperty(EPCommonSystemProperties.EXTERNAL_SYSTEM_NOTIFICATION_URL)+ticket);
        }
-
 }