Use setVariablesLocal for setting task variables

Use setVariablesLocal for setting task variables in a correct scope in
Camunda.
Wait for task to be created before query to address robot test slowdown.

Issue-ID: SO-2761
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I8229326f48936dc4bc59162341c12355a64982a5

diff --git a/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/manualhandling/tasks/ManualHandlingTasks.java b/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/manualhandling/tasks/ManualHandlingTasks.java
index d9f5e65..cdba6e0 100644 (file)
--- a/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/manualhandling/tasks/ManualHandlingTasks.java
+++ b/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/manualhandling/tasks/ManualHandlingTasks.java
@@ -173,7 +173,7 @@ public class ManualHandlingTasks {
             taskVariables.put(TASK_VARIABLE_DESCRIPTION, description);
             TaskService taskService = execution.getProcessEngineServices().getTaskService();
 
-            taskService.setVariables(taskId, taskVariables);
+            taskService.setVariablesLocal(taskId, taskVariables);
             logger.debug("successfully created fallout task: " + taskId);
         } catch (BpmnError e) {
             logger.debug(BPMN_EXCEPTION + e.getMessage());
@@ -223,7 +223,7 @@ public class ManualHandlingTasks {
             taskVariables.put(TASK_VARIABLE_VALID_RESPONSES, validResponses);
             TaskService taskService = execution.getProcessEngineServices().getTaskService();
 
-            taskService.setVariables(taskId, taskVariables);
+            taskService.setVariablesLocal(taskId, taskVariables);
             logger.debug("successfully created pause task: " + taskId);
         } catch (BpmnError e) {
             logger.debug(BPMN_EXCEPTION + e.getMessage());

diff --git a/bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/manualhandling/tasks/ManualHandlingTasksTest.java b/bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/manualhandling/tasks/ManualHandlingTasksTest.java
index b6dcd96..e3bbd11 100644 (file)
--- a/bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/manualhandling/tasks/ManualHandlingTasksTest.java
+++ b/bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/manualhandling/tasks/ManualHandlingTasksTest.java
@@ -100,7 +100,7 @@ public class ManualHandlingTasksTest extends BaseTaskTest {
         when(mockExecution.getProcessEngineServices()).thenReturn(processEngineServices);
         when(processEngineServices.getTaskService()).thenReturn(taskService);
         manualHandlingTasks.setFalloutTaskVariables(task);
-        verify(taskService, times(1)).setVariables(any(String.class), any(Map.class));
+        verify(taskService, times(1)).setVariablesLocal(any(String.class), any(Map.class));
     }
 
     @Test
@@ -110,7 +110,7 @@ public class ManualHandlingTasksTest extends BaseTaskTest {
         when(mockExecution.getProcessEngineServices()).thenReturn(processEngineServices);
         when(processEngineServices.getTaskService()).thenReturn(taskService);
         manualHandlingTasks.setPauseTaskVariables(task);
-        verify(taskService, times(1)).setVariables(any(String.class), any(Map.class));
+        verify(taskService, times(1)).setVariablesLocal(any(String.class), any(Map.class));
     }
 
     @Test