lowered code smells in ReportSchedule.java

lowered code smells in ReportSchedule.java

Issue-ID: PORTAL-813
Change-Id: I4b8af64a260c4bf3339a80a93a064726b554ad3a
Signed-off-by: Indrijeet Kumar <indriku1@in.ibm.com>

diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportSchedule.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportSchedule.java
index 4a5aa77..5ceae66 100644 (file)
--- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportSchedule.java
+++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportSchedule.java
@@ -1035,7 +1035,6 @@ public class ReportSchedule extends RaptorObject implements Serializable{
                                c_sql = c_sql.replace("[getScheduleID()]", getScheduleID());
                                
                                sb.append(c_sql);
-                               //sb.append("DELETE FROM cr_report_schedule where rep_id = " + reportID +" and sched_user_id = " + getScheduleUserID() + " and schedule_id = " + getScheduleID());
                                
                                DbUtils.executeUpdate(connection, sb.toString());
                        }
@@ -1134,8 +1133,6 @@ public class ReportSchedule extends RaptorObject implements Serializable{
                
                try {
                        connection = DbUtils.getConnection();
-
-                       //String sql = "SELECT condition_large_sql FROM cr_report_schedule WHERE schedule_id=?";
                        String sql = Globals.getLoadCondSql();
                        stmt = connection.prepareStatement(sql);
                        stmt.setString(1,scheduleId);
@@ -1212,12 +1209,10 @@ public class ReportSchedule extends RaptorObject implements Serializable{
                ResultSet rs = null;
 
                try {
-                       //String sql = "update cr_report_schedule set condition_large_sql = EMPTY_CLOB() where  schedule_id = " + scheduleId;
                        String sql = Globals.getPersistCondSqlUpdate();
                        sql = sql.replace("[scheduleId]", scheduleId);
                        
                        DbUtils.executeUpdate(sql);
-                       //sql = "SELECT condition_large_sql FROM cr_report_schedule cr WHERE schedule_id=?       FOR UPDATE";
                        sql = Globals.getPersistCondSqlLarge();
                        stmt = connection.prepareStatement(sql);
                        stmt.setString(1,scheduleId);
@@ -1237,7 +1232,6 @@ public class ReportSchedule extends RaptorObject implements Serializable{
                } catch (RaptorException ex) {
                        if(ex.getMessage().indexOf("invalid identifier")!= -1) {
                                try {
-                               //String sql = "update cr_report_schedule set condition_sql = ? where schedule_id = " + scheduleId;
                                String sql = Globals.getPersistCondSqlSet();
                                sql = sql.replace("[scheduleId]", scheduleId);
                                        stmt = connection.prepareStatement(sql);