[POLICY-134] Fixed bug in PolicyLogger. 33/6433/2
authorMagnusen, Drew (dm741q) <dm741q@att.com>
Mon, 31 Jul 2017 17:51:51 +0000 (12:51 -0500)
committerMagnusen, Drew (dm741q) <dm741q@att.com>
Tue, 1 Aug 2017 13:36:08 +0000 (08:36 -0500)
PolicyLogger.info(Object arg0) calls itself recursively until it eventually
causes a stack overflow error.

Fix is to call debugLogger.info(MessageCodes, String) from within
PolicyLogger.info(Object).

Additionally, PolicyLogger.info(String arg0) was removed as
debugLogger.info(MessageCodes, String) can be called directly.

Change-Id: Id141027b544efa06b79f54a6726843b2a47481b9
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java

index d0cc9c1..7507c9e 100644 (file)
@@ -366,14 +366,6 @@ public class PolicyLogger {
                debugLogger.info(MessageCodes.GENERAL_INFO, arg0);
        }
 
-       /**
-        * Records only one String message without its class name passed in
-        * @param arg0
-        */
-       public static void info(String arg0) {
-               MDC.put(CLASS_NAME, "");
-               debugLogger.info(MessageCodes.GENERAL_INFO, arg0);
-       }
        
        /**
         * Records only one String message
@@ -381,7 +373,7 @@ public class PolicyLogger {
         */
        public static void info(Object arg0) {
                MDC.put(CLASS_NAME, "");
-               info(arg0);
+               debugLogger.info(MessageCodes.GENERAL_INFO, String.valueOf(arg0));
        }
 
        /**