Sonar major issues 33/60433/1
authorSumapriya Sarvepalli <ss00493505@techmahindra.com>
Tue, 14 Aug 2018 05:49:37 +0000 (11:19 +0530)
committerSumapriya Sarvepalli <ss00493505@techmahindra.com>
Tue, 14 Aug 2018 05:49:37 +0000 (11:19 +0530)
 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.portal.sdk%3Aepsdk-project&open=AV_om9w5-08if2a6uh0R&resolved=false
Location:
ecomp-sdk/ONAP Portal SDK Webapp/ Common/src/main/java/org/onap/portalapp/controller/sample/PostDroolsController.java
Line No: L78 L100 L129

Change-Id: Id85ee4482679942031fee8c57571b2415d6b15fe
Issue-ID: PORTAL-355
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/PostDroolsController.java

index fb0338e..43d548f 100644 (file)
@@ -75,7 +75,7 @@ public class PostDroolsController extends RestrictedBaseController {
 
        @RequestMapping(value = { "/getDrools" }, method = RequestMethod.GET)
        public void getDrools(HttpServletRequest request, HttpServletResponse response) {
-               // Map<String, Object> model = new HashMap<String, Object>();
+               
 
                ObjectMapper mapper = new ObjectMapper();
                try {
@@ -97,7 +97,6 @@ public class PostDroolsController extends RestrictedBaseController {
                        PostDroolsBean postDroolsBean = new PostDroolsBean();
                        String selectedFile = request.getParameter("selectedFile");
                        postDroolsBean.setDroolsFile(selectedFile);// sample populated
-                       // postDroolsBean.setSelectedRules("[\"NJ\",\"NY\",\"KY\"]");
                        postDroolsBean.setClassName(postDroolsService.retrieveClass(selectedFile));
 
                        JsonMessage msg = new JsonMessage(mapper.writeValueAsString(postDroolsBean));
@@ -126,7 +125,6 @@ public class PostDroolsController extends RestrictedBaseController {
                        request.setCharacterEncoding("UTF-8");
 
                        PrintWriter out = response.getWriter();
-                       // String responseString = mapper.writeValueAsString(resultsString);
                        JSONObject j = new JSONObject("{resultsString: " + resultsString + "}");
 
                        out.write(j.toString());