Merge this if statement with the enclosing one 27/98027/2
authoranushadasari <danush10@in.ibm.com>
Wed, 6 Nov 2019 09:33:30 +0000 (15:03 +0530)
committerVikas Varma <vv8305@att.com>
Wed, 22 Jan 2020 15:28:28 +0000 (15:28 +0000)
Merging collapsible if statements increases the code's readability.

Issue-ID: OPTFRA-634
Change-Id: Ic1c24c2671f62282477e32c432216ac560745c03
Signed-off-by: anushadasari <danush10@in.ibm.com>
cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafAuthProvider.java

index 332ca73..0a7a69e 100755 (executable)
@@ -66,11 +66,9 @@ public class AafAuthProvider implements AuthenticationProvider {
                 sessionId = webAuthDetails.getRemoteAddress() + ":" + webAuthDetails.getSessionId();\r
             }\r
         }\r
-        if (env.getProperty(AafProperties.aafEnabled.toString(), Boolean.class, true)) {\r
-            if (clientCache.authenticate(name, password, sessionId) != AuthorizationResult.Authenticated) {\r
+        if (env.getProperty(AafProperties.aafEnabled.toString(), Boolean.class, true) && clientCache.authenticate(name, password, sessionId) != AuthorizationResult.Authenticated ) {\r
                 return null;\r
             }\r
-        }\r
         return new UsernamePasswordAuthenticationToken(name, password, new ArrayList<>());\r
 \r
     }\r