General sonar fixes

+) Add logger to log exception
++) Format logger

Issue-ID: SO-2187
Change-Id: Id77271340070a61e7ce82822321d7e5b8b03f759
Signed-off-by: arind.mondal <arind.mondal@samsung.com>

diff --git a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/audit/AuditVServer.java b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/audit/AuditVServer.java
index 89e0320..14d83b3 100644 (file)
--- a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/audit/AuditVServer.java
+++ b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/audit/AuditVServer.java
@@ -84,8 +84,9 @@ public class AuditVServer extends AbstractAudit {
             try {
                 logger.debug("Vserver to Audit: {}", objectMapper.getMapper().writeValueAsString(vserver));
             } catch (JsonProcessingException e) {
-
+                logger.error("Json parse exception: {}", e.getMessage());
             }
+
         });
         AAIObjectAuditList auditList = new AAIObjectAuditList();
         vServersToAudit.stream().forEach(vServer -> auditList.getAuditList()

diff --git a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/vnf/MsoVnfPluginAdapterImpl.java b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/vnf/MsoVnfPluginAdapterImpl.java
index 70fb0b3..d5fe285 100644 (file)
--- a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/vnf/MsoVnfPluginAdapterImpl.java
+++ b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/vnf/MsoVnfPluginAdapterImpl.java
@@ -616,7 +616,7 @@ public class MsoVnfPluginAdapterImpl implements MsoVnfAdapter {
             vnfResource = vfModuleCust.getVfModule().getVnfResources();
         } catch (Exception e) {
 
-            logger.debug("unhandled exception in create VF - [Query]" + e.getMessage());
+            logger.debug("unhandled exception in create VF - [Query] {}", e.getMessage());
             throw new VnfException("Exception during create VF " + e.getMessage());
         }
 

diff --git a/adapters/mso-vnfm-adapter/mso-vnfm-etsi-adapter/src/main/java/org/onap/so/adapters/vnfmadapter/jobmanagement/JobManager.java b/adapters/mso-vnfm-adapter/mso-vnfm-etsi-adapter/src/main/java/org/onap/so/adapters/vnfmadapter/jobmanagement/JobManager.java
index 19c8d22..d01e5b1 100644 (file)
--- a/adapters/mso-vnfm-adapter/mso-vnfm-etsi-adapter/src/main/java/org/onap/so/adapters/vnfmadapter/jobmanagement/JobManager.java
+++ b/adapters/mso-vnfm-adapter/mso-vnfm-etsi-adapter/src/main/java/org/onap/so/adapters/vnfmadapter/jobmanagement/JobManager.java
@@ -101,8 +101,7 @@ public class JobManager {
             }
             final InlineResponse200 operation = operationOptional.get();
 
-            logger.debug(
-                    "Job Id: " + jobId + ", operationId: " + operation.getId() + ", operation details: " + operation);
+            logger.debug("Job Id: {} operationId: {} operation details: {} ", jobId, operation.getId(), operation);
 
             if (operation.getOperationState() == null) {
                 return response.operationStatusRetrievalStatus(OperationStatusRetrievalStatusEnum.WAITING_FOR_STATUS);
@@ -148,7 +147,8 @@ public class JobManager {
         if (relatedOperation.isPresent()) {
             relatedOperation.get().setNotificationProcessed(notificationProcessingWasSuccessful);
         } else {
-            logger.debug("No operation found for operation ID " + operationId);
+            logger.debug("No operation found for operation ID {} ", operationId);
+
         }
     }
 
@@ -159,7 +159,7 @@ public class JobManager {
         if (relatedOperation.isPresent()) {
             relatedOperation.get().setVnfDeleted();;
         } else {
-            logger.debug("No operation found for operation ID " + operationId);
+            logger.debug("No operation found for operation ID {} ", operationId);
         }
     }