Fix Sonar Issue in sli/adaptors module 25/13725/1
authorsurya-huawei <a.u.surya@huawei.com>
Wed, 20 Sep 2017 06:52:35 +0000 (12:22 +0530)
committersurya-huawei <a.u.surya@huawei.com>
Wed, 20 Sep 2017 06:54:31 +0000 (12:24 +0530)
One blocker issue
*Checking for a null dereferencing
This is to avoid NullPointerException

Issue-Id: CCSDK-87
Change-Id: Ie2192636e3ad8dfa9643cac61b3086c3cd33f126
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/ResourceDaoImpl.java

index 7db37ff..58f1036 100644 (file)
@@ -331,14 +331,16 @@ public class ResourceDaoImpl implements ResourceDao {
             ai = rai;
         }
 
-        ai.resourceType = r.resourceType;
-        ai.resourceKey = r.resourceKey;
-        ai.resourceSetId = aiEntity.resourceSetId;
-        ai.resourceUnionId = aiEntity.resourceUnionId;
-        if (aiEntity.resourceShareGroupList != null)
-            ai.resourceShareGroupList = new HashSet<String>(StrUtil.listStr(aiEntity.resourceShareGroupList));
-        ai.applicationId = aiEntity.applicationId;
-        ai.allocationTime = aiEntity.allocationTime;
+        if (ai!=null) {
+            ai.resourceType = r.resourceType;
+            ai.resourceKey = r.resourceKey;
+            ai.resourceSetId = aiEntity.resourceSetId;
+            ai.resourceUnionId = aiEntity.resourceUnionId;
+            if (aiEntity.resourceShareGroupList != null)
+                ai.resourceShareGroupList = new HashSet<String>(StrUtil.listStr(aiEntity.resourceShareGroupList));
+            ai.applicationId = aiEntity.applicationId;
+            ai.allocationTime = aiEntity.allocationTime;
+        }
 
         return ai;
     }