removed code smells in Globals.java

removed code smells in Globals.java

Issue-ID: PORTAL-813
Change-Id: I5aa5a4919cd9ffb128256783b48a3eafd2caa69d
Signed-off-by: Indrijeet Kumar <indriku1@in.ibm.com>

diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/Globals.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/Globals.java
index b64f8e0..6d9c94f 100644 (file)
--- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/Globals.java
+++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/Globals.java
@@ -990,10 +990,6 @@ return sheetName;
                }       
        return limit;
     }
-    
-//    public static String getWhereConditionForUserRole() {
-//             return nvls(raptorProperties.getProperty("schedule_where_condition"),"").trim();
-//    }
     public static String getCustomizedScheduleQueryForUsers() {
        return nvls(raptorProperties.getProperty("schedule_custom_query_for_users"),"").trim();
     }
@@ -1336,65 +1332,6 @@ return sheetName;
                List formParameter = new ArrayList();
                String formField = "";
                
-//             for(int i = 1 ; i < (countOfFields+1); i++)
-//             {
-//                     formField ="ff"+i;
-//                     
-//                              if(request.getParameterValues(formField) != null && request.getParameterValues(formField).length > 1 )
-//                                     {
-//                                             String[] vals = request.getParameterValues(formField);
-//                                             boolean isMultiValue = false;
-//                                             StringBuffer value = new StringBuffer("");
-//                                             if(vals.length > 1) {
-//                                                     isMultiValue = true;
-//                                                     value.append("(");
-//                                             }
-//                                             for(int j = 0 ; j < vals.length; j++)
-//                                             {
-//                                                     if(isMultiValue) value.append("'");
-//                                                     try {
-//                                                             if(vals[j] !=null && vals[j].length() > 0)
-//                                                                     value.append(java.net.URLDecoder.decode(vals[j], "UTF-8"));// + ",";
-//                                                             else
-//                                                                     value.append(vals[j]);
-//                                                     } catch (UnsupportedEncodingException ex) {value.append(vals[j]);}
-//                                                     catch (IllegalArgumentException ex1){value.append(vals[j]);} 
-//                                                     catch (Exception ex2){value.append(vals[j]);}
-//
-//
-//                                                     if(isMultiValue) value.append("'"); 
-//                                                     
-//                                                     if(j != vals.length -1) {
-//                                                             value.append(",");
-//                                                     }
-//                                             }
-//                                             if(vals.length > 1) {
-//                                                     value.append(")");
-//                                             }
-//                                             
-//                                             //value = value.substring(0 , value.length());  
-//                                      
-//                                      valuesMap.put(fieldNameMap.get(formField), value.toString());
-//                                      value = new StringBuffer("");
-//                                             
-//                                     }
-//                             else if(request.getParameter(formField) != null)
-//                             {
-//                                     String value = "";
-//                                     value = request.getParameter(formField);
-//                                     try {
-//                                             if(value !=null && value.length() > 0)
-//                                             value = java.net.URLDecoder.decode(request.getParameter(formField), "UTF-8");
-//                                     } catch (UnsupportedEncodingException ex) {}
-//                                     catch (IllegalArgumentException ex1){}
-//                                     catch (Exception ex2){}
-//                                     valuesMap.put(fieldNameMap.get(formField), value);
-//                                     
-//                             }else
-//                             {
-//                                     valuesMap.put(fieldNameMap.get(formField), "NULL" );
-//                             }
-//             }
                for(int i = 0 ; i < rff.size(); i++) {
                        ff = ((FormField)rff.getFormField(i));
                        formField = ff.getFieldName();