fixing major Sonar Issue

12 more branches need to be covered to reach 65% coverage
Sonar Link:
https://sonar.onap.org/project/issues?assignees=ThamlurRaju&id=org.onap.vfc.nfvo.resmanagement%3Avfc-nfvo-resmanagement&open=AV8lpe4u-08if2a6pmAh&resolved=false&severities=MAJOR&types=CODE_SMELL
Location:
src/main/java/org/onap/vfc/nfvo/resmanagement/common/util/restclient/RestfulConfigure.java

Change-Id: Ib400c61e307085dcaa8525a0d24fb167b3edf2ce
Issue-ID: VFC-1043
Signed-off-by: ThamlurRaju <thamlurraju468@gmail.com>

diff --git a/ResmanagementService/service/src/test/java/org/onap/vfc/nfvo/resmanagement/common/util/restclient/RestfulConfigureTest.java b/ResmanagementService/service/src/test/java/org/onap/vfc/nfvo/resmanagement/common/util/restclient/RestfulConfigureTest.java
new file mode 100644 (file)
index 0000000..b4be827
--- /dev/null
+++ b/ResmanagementService/service/src/test/java/org/onap/vfc/nfvo/resmanagement/common/util/restclient/RestfulConfigureTest.java
@@ -0,0 +1,88 @@
+/*
+ * Copyright 2016 Huawei Technologies Co., Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.onap.vfc.nfvo.resmanagement.common.util.restclient;
+
+import static org.junit.Assert.assertTrue;
+
+import java.io.IOException;
+
+import org.junit.Test;
+
+import net.sf.json.JSONException;
+
+public class RestfulConfigureTest {
+
+       @Test
+       public void testRestfulConfigure() {
+                RestfulConfigure rc = new  RestfulConfigure();
+                rc.toString();
+       }
+       
+       @Test
+       public void testRestfulConfigureStringNoFilePath() {
+                RestfulConfigure rc = new  RestfulConfigure("");
+               rc.getOptions();
+                assertTrue(true);
+       }
+
+       @Test
+       public void testRestfulConfigureStringNoFileExist() {
+                RestfulConfigure rc = new  RestfulConfigure("C:/Users/Desktop");
+                rc.getOptions();
+                assertTrue(true);
+       }
+       
+       @Test
+       public void testRestfulConfigureString() {
+                RestfulConfigure rc = new  RestfulConfigure("src/test/resources/Check7.txt");
+                rc.getOptions();
+                assertTrue(true);
+       }
+       
+       @Test
+       public void testRestfulConfigureStringNoFile() {
+                RestfulConfigure rc = new  RestfulConfigure("src/test/resources/Check1.txt");
+                rc.getOptions();
+                assertTrue(true);
+       }
+       
+       @Test
+       public void testRestfulConfigureStringWrongFile() {
+                RestfulConfigure rc = new  RestfulConfigure("src/test/resources/Check2.txt");
+                rc.getOptions();
+                assertTrue(true);
+       }
+       
+       @Test
+       public void testRestfulConfigureStringEmptyFile() {
+                RestfulConfigure rc = new  RestfulConfigure("src/test/resources/Check3.txt");
+                rc.getOptions();
+                assertTrue(true);
+       }
+       @Test
+       public void testRestfulConfigureStringNoHostFile() {
+                RestfulConfigure rc = new  RestfulConfigure("src/test/resources/Check4.txt");
+                rc.getOptions();
+                assertTrue(true);
+       }
+       
+       @Test(expected=JSONException.class)
+       public void testRestfulConfigureStringZeroFile() throws IOException {
+                RestfulConfigure rc = new  RestfulConfigure("src/test/resources/Check5.txt");
+                rc.getOptions();
+       }
+}

diff --git a/ResmanagementService/service/src/test/resources/Check2.txt b/ResmanagementService/service/src/test/resources/Check2.txt
new file mode 100644 (file)
index 0000000..926dc20
--- /dev/null
+++ b/ResmanagementService/service/src/test/resources/Check2.txt
@@ -0,0 +1,12 @@
+{
+    "defaultServer":
+    {
+        "host":"",
+        "port":"80"
+    },
+"ConnectTimeout":"300000",
+"thread":"10",
+"idletimeout":"500000",
+"timeout":"300000"
+}
+               
\ No newline at end of file

diff --git a/ResmanagementService/service/src/test/resources/Check3.txt b/ResmanagementService/service/src/test/resources/Check3.txt
new file mode 100644 (file)
index 0000000..08e3741
--- /dev/null
+++ b/ResmanagementService/service/src/test/resources/Check3.txt
@@ -0,0 +1,12 @@
+{
+    "":
+    {
+        "host":"",
+        "port":""
+    },
+"":"",
+"":"",
+"":"",
+"":""
+}
+               
\ No newline at end of file

diff --git a/ResmanagementService/service/src/test/resources/Check4.txt b/ResmanagementService/service/src/test/resources/Check4.txt
new file mode 100644 (file)
index 0000000..7ccbf2b
--- /dev/null
+++ b/ResmanagementService/service/src/test/resources/Check4.txt
@@ -0,0 +1,12 @@
+{
+    "defaultServer":
+    {
+        "":"127.0.0.1",
+        "port":"80"
+    },
+"ConnectTimeout":"300000",
+"thread":"10",
+"idletimeout":"500000",
+"timeout":"300000"
+}
+               
\ No newline at end of file

diff --git a/ResmanagementService/service/src/test/resources/Check5.txt b/ResmanagementService/service/src/test/resources/Check5.txt
new file mode 100644 (file)
index 0000000..e69de29

diff --git a/ResmanagementService/service/src/test/resources/Check7.txt b/ResmanagementService/service/src/test/resources/Check7.txt
new file mode 100644 (file)
index 0000000..47c4e08
--- /dev/null
+++ b/ResmanagementService/service/src/test/resources/Check7.txt
@@ -0,0 +1,12 @@
+{
+    "defaultServer":
+    {
+        "host":"127.0.0.1",
+        "port":"80"
+    },
+"ConnectTimeout":"300000",
+"thread":"10",
+"idletimeout":"500000",
+"timeout":"300000"
+}
+               
\ No newline at end of file