Fixed the bugs checked by sonar.

Add keyword 'final' to the public static member variables of classes.

Issue-ID: SDC-1079

Change-Id: If1e68e4fa5e5709c0a42095bceb7ab3bf97143ac
Signed-off-by: YuanHu <yuan.hu1@zte.com.cn>

diff --git a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/config/Config.java b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/config/Config.java
index 601822d..91cd498 100644 (file)
--- a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/config/Config.java
+++ b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/config/Config.java
@@ -22,10 +22,10 @@ import org.slf4j.LoggerFactory;
 public class Config {\r
     private static Logger log = LoggerFactory.getLogger(Config.class);\r
     private static String configFilePath = "bpmn.config.properties";\r
-    public static String HANDLER_ClASS = "handlerClass";\r
-    public static String TEMPLATE_PATH = "templatePath";\r
+    public final static String HANDLER_ClASS = "handlerClass";\r
+    public final static String TEMPLATE_PATH = "templatePath";\r
 \r
-    public static Properties PROPERTIES = load();\r
+    public final static Properties PROPERTIES = load();\r
 \r
     public static Properties load() {\r
         Properties properties = new Properties();\r

diff --git a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/EndEvent.java b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/EndEvent.java
index 52818e7..c25e623 100644 (file)
--- a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/EndEvent.java
+++ b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/EndEvent.java
@@ -12,5 +12,5 @@
 package org.onap.sdc.workflowdesigner.model;\r
 \r
 public class EndEvent extends Element {\r
-    public static String type = "endEvent";\r
+    public final static String TYPE = "endEvent";\r
 }\r

diff --git a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/ExclusiveGateway.java b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/ExclusiveGateway.java
index eb0f4bb..77bc28c 100644 (file)
--- a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/ExclusiveGateway.java
+++ b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/ExclusiveGateway.java
@@ -12,5 +12,5 @@
 package org.onap.sdc.workflowdesigner.model;\r
 \r
 public class ExclusiveGateway extends Element {\r
-    public static String type = "exclusiveGateway";\r
+    public final static String TYPE = "exclusiveGateway";\r
 }\r

diff --git a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/ParallelGateway.java b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/ParallelGateway.java
index 93fae50..b56aa33 100644 (file)
--- a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/ParallelGateway.java
+++ b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/ParallelGateway.java
@@ -12,5 +12,5 @@
 package org.onap.sdc.workflowdesigner.model;\r
 \r
 public class ParallelGateway extends Element {\r
-    public static String type = "parallelGateway";\r
+    public final static String TYPE = "parallelGateway";\r
 }\r

diff --git a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/RestServiceTask.java b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/RestServiceTask.java
index 6110132..173c4da 100644 (file)
--- a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/RestServiceTask.java
+++ b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/model/RestServiceTask.java
@@ -16,7 +16,7 @@ import java.util.List;
 import org.onap.sdc.workflowdesigner.config.Config;\r
 \r
 public class RestServiceTask extends ServiceTask {\r
-       public static String handler = Config.PROPERTIES.getProperty(Config.HANDLER_ClASS);\r
+    private static String handler = Config.PROPERTIES.getProperty(Config.HANDLER_ClASS);\r
        \r
        private String restConfigId;\r
        public String getRestConfigId() {\r

diff --git a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/writer/BpmnPlanArtefactWriter.java b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/writer/BpmnPlanArtefactWriter.java
index ee6a6e5..89e0c8c 100644 (file)
--- a/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/writer/BpmnPlanArtefactWriter.java
+++ b/sdc-workflow-designer-server/src/main/java/org/onap/sdc/workflowdesigner/writer/BpmnPlanArtefactWriter.java
@@ -28,7 +28,7 @@ public class BpmnPlanArtefactWriter {
 \r
     private Process process;\r
 \r
-    public static String TEMPLATE_PATH = Config.PROPERTIES.getProperty(Config.TEMPLATE_PATH);\r
+    private final static String TEMPLATE_PATH = Config.PROPERTIES.getProperty(Config.TEMPLATE_PATH);\r
 \r
     private static Logger log = LoggerFactory.getLogger(BpmnPlanArtefactWriter.class);\r
 \r