Refactor CommandTask and its subclasses to be immutable.
Also made CommandResponse immutable.
Change-Id: I9ea1b57fdff677b163c0fe9ad5d48f24b781a08f
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
public class CommandResponse {
- private RuntimeContext runtimeContext;
+ private final RuntimeContext runtimeContext;
- public RuntimeContext getRuntimeContext() {
- return runtimeContext;
+ public CommandResponse(RuntimeContext runtimeContext) {
+ super();
+ this.runtimeContext = runtimeContext;
}
- public void setRuntimeContext(RuntimeContext runtimeContext) {
- this.runtimeContext = runtimeContext;
+ public RuntimeContext getRuntimeContext() {
+ return runtimeContext;
}
}
logger.trace("Entering to enqueRequest with CommandRequest = "+ ObjectUtils.toString(request));
}
try {
- CommandTask commandTask = getMessageExecutor(request.getRequestContext().getAction().name());
- commandTask.setCommandRequest(request);
+ String action = request.getRequestContext().getAction().name();
+ CommandTask commandTask = executionTaskFactory.getExecutionTask(action, request);
long remainingTTL = getRemainingTTL(request);
executionQueueService.putMessage(commandTask,remainingTTL, TimeUnit.MILLISECONDS);
} catch (Exception e) {
return ChronoUnit.MILLIS.between(Instant.now(), requestTimestamp.plusSeconds(ttl));
}
- private CommandTask getMessageExecutor(String action){
- if (logger.isTraceEnabled()) {
- logger.trace("Entering to getMessageExecutor with command = "+ action);
- }
- CommandTask executionTask = executionTaskFactory.getExecutionTask(action);
- if (logger.isTraceEnabled()) {
- logger.trace("Exiting from getMessageExecutor");
- }
- return executionTask;
- }
-
}
public abstract class CommandTask implements Runnable {
- protected RequestHandler requestHandler;
- protected WorkFlowManager workflowManager;
+ protected final RequestHandler requestHandler;
+ protected final WorkFlowManager workflowManager;
+ protected final RuntimeContext commandRequest;
- private RuntimeContext commandRequest;
-
- public RuntimeContext getCommandRequest() {
- return commandRequest;
- }
-
- public void setCommandRequest(RuntimeContext commandRequest) {
+ protected CommandTask(RuntimeContext commandRequest, RequestHandler requestHandler,
+ WorkFlowManager workflowManager) {
+ super();
this.commandRequest = commandRequest;
- }
-
- private static final EELFLogger logger = EELFManager.getInstance().getLogger(CommandTask.class);
-
- public void setWorkflowManager(WorkFlowManager workflowManager) {
- this.workflowManager = workflowManager;
- }
-
- public void setRequestHandler(RequestHandler requestHandler) {
this.requestHandler = requestHandler;
+ this.workflowManager = workflowManager;
}
- CommandTask(){
- }
+ private static final EELFLogger logger = EELFManager.getInstance().getLogger(CommandTask.class);
- public void onRequestCompletion(RuntimeContext request, CommandResponse response , boolean isAAIUpdated) {
+ public void onRequestCompletion(CommandResponse response, boolean isAAIUpdated) {
logger.debug("Entry: onRequestCompletion()");
- requestHandler.onRequestExecutionEnd(request, isAAIUpdated);
+ requestHandler.onRequestExecutionEnd(commandRequest, isAAIUpdated);
}
- public abstract void onRequestCompletion(RuntimeContext request, CommandResponse response);
+ public abstract void onRequestCompletion(CommandResponse response);
- protected CommandResponse buildCommandResponse(RuntimeContext request, WorkflowResponse response) {
+ protected CommandResponse buildCommandResponse(WorkflowResponse response) {
- CommandResponse commandResponse = new CommandResponse();
- commandResponse.setRuntimeContext(request);
- return commandResponse;
+ return new CommandResponse(commandRequest);
}
WorkflowResponse response = workflowManager.executeWorkflow(workflowRequest);
- CommandResponse commandResponse = buildCommandResponse(commandRequest, response);
- this.onRequestCompletion(commandRequest,commandResponse);
+ CommandResponse commandResponse = buildCommandResponse(response);
+ this.onRequestCompletion(commandResponse);
}
}
package org.openecomp.appc.executor.impl;
+import org.openecomp.appc.domainmodel.lcm.RuntimeContext;
import org.openecomp.appc.domainmodel.lcm.VNFOperation;
import org.openecomp.appc.lifecyclemanager.LifecycleManager;
import org.openecomp.appc.requesthandler.RequestHandler;
}
- public synchronized CommandTask getExecutionTask(String action){
+ public synchronized CommandTask getExecutionTask(String action, RuntimeContext commandRequest){
if (VNFOperation.Sync.toString().equals(action) || VNFOperation.Audit.toString().equals(action)){
- return new LCMReadonlyCommandTask(requestHandler,workflowManager);
+ return new LCMReadonlyCommandTask(commandRequest, requestHandler,workflowManager);
}else {
- return new LCMCommandTask(requestHandler,workflowManager,
+ return new LCMCommandTask(commandRequest, requestHandler,workflowManager,
lifecyclemanager);
}
}
package org.openecomp.appc.executor.impl;
+import java.util.HashMap;
+import java.util.Map;
+
import org.apache.commons.lang3.StringUtils;
import org.openecomp.appc.domainmodel.lcm.CommonHeader;
import org.openecomp.appc.domainmodel.lcm.RuntimeContext;
-import org.openecomp.appc.domainmodel.lcm.Status;
import org.openecomp.appc.domainmodel.lcm.VNFOperation;
import org.openecomp.appc.executor.UnstableVNFException;
import org.openecomp.appc.executor.objects.CommandResponse;
import org.openecomp.appc.requesthandler.RequestHandler;
import org.openecomp.appc.workflow.WorkFlowManager;
import org.openecomp.appc.workflow.objects.WorkflowResponse;
-import com.att.eelf.configuration.EELFLogger;
-import com.att.eelf.configuration.EELFManager;
import org.openecomp.sdnc.sli.SvcLogicContext;
import org.openecomp.sdnc.sli.SvcLogicException;
import org.openecomp.sdnc.sli.SvcLogicResource;
import org.osgi.framework.FrameworkUtil;
import org.osgi.framework.ServiceReference;
-import java.util.HashMap;
-import java.util.Map;
+import com.att.eelf.configuration.EELFLogger;
+import com.att.eelf.configuration.EELFManager;
public class LCMCommandTask extends CommandTask {
- private AAIService aaiService;
- private LifecycleManager lifecyclemanager;
+ private final AAIService aaiService;
+ private final LifecycleManager lifecyclemanager;
private static final EELFLogger logger = EELFManager.getInstance().getLogger(LCMCommandTask.class);
- public LCMCommandTask(RequestHandler requestHandler, WorkFlowManager workflowManager,
- LifecycleManager lifecyclemanager){
- setRequestHandler(requestHandler);
- setWorkflowManager(workflowManager);
- setLifecyclemanager(lifecyclemanager);
- getAAIservice();
- }
-
- public void setLifecyclemanager(LifecycleManager lifecyclemanager) {
- this.lifecyclemanager = lifecyclemanager;
- }
+ public LCMCommandTask(RuntimeContext commandRequest, RequestHandler requestHandler, WorkFlowManager workflowManager,
+ LifecycleManager lifecyclemanager) {
+ super(commandRequest, requestHandler, workflowManager);
+ this.lifecyclemanager = lifecyclemanager;
-
- private void getAAIservice() {
BundleContext bctx = FrameworkUtil.getBundle(AAIService.class).getBundleContext();
// Get AAIadapter reference
ServiceReference sref = bctx.getServiceReference(AAIService.class.getName());
} else {
logger.info("AAIService error from bundlecontext");
logger.warn("Cannot find service reference for org.openecomp.sdnc.sli.aai.AAIService");
-
+ aaiService = null;
}
}
@Override
- public void onRequestCompletion(RuntimeContext request, CommandResponse response) {
-
- boolean isAAIUpdated = false;
+ public void onRequestCompletion(CommandResponse response) {
+ final RuntimeContext request = commandRequest;
+ boolean isAAIUpdated = false;
try {
final int statusCode = request.getResponseContext().getStatus().getCode();
throw new RuntimeException(e1);
}
finally {
- super.onRequestCompletion(request, response , isAAIUpdated);
+ super.onRequestCompletion(response, isAAIUpdated);
}
}
@Override
public void run() {
- RuntimeContext request = getCommandRequest();
- boolean isAAIUpdated;
+ final RuntimeContext request = commandRequest;
+ boolean isAAIUpdated = false;
final String vnfId = request.getVnfContext().getId();
final String vnfType = request.getVnfContext().getType();
try {
logger.error(errorMsg);
WorkflowResponse response = new WorkflowResponse();
response.setResponseContext(request.getResponseContext());
- CommandResponse commandResponse = super.buildCommandResponse(request, response);
- this.onRequestCompletion(request,commandResponse);
+ CommandResponse commandResponse = super.buildCommandResponse(response);
+ this.onRequestCompletion(commandResponse);
}
}
import org.apache.commons.lang3.StringUtils;
import org.openecomp.appc.domainmodel.lcm.CommonHeader;
import org.openecomp.appc.domainmodel.lcm.RuntimeContext;
-import org.openecomp.appc.domainmodel.lcm.Status;
import org.openecomp.appc.executor.UnstableVNFException;
import org.openecomp.appc.executor.objects.CommandResponse;
import org.openecomp.appc.executor.objects.LCMCommandStatus;
import org.openecomp.appc.executor.objects.UniqueRequestIdentifier;
import org.openecomp.appc.requesthandler.RequestHandler;
import org.openecomp.appc.workflow.WorkFlowManager;
+
import com.att.eelf.configuration.EELFLogger;
import com.att.eelf.configuration.EELFManager;
private static final EELFLogger logger = EELFManager.getInstance().getLogger(LCMReadonlyCommandTask.class);
- public LCMReadonlyCommandTask(RequestHandler requestHandler, WorkFlowManager workflowManager){
-
- setRequestHandler(requestHandler);
- setWorkflowManager(workflowManager);
+ public LCMReadonlyCommandTask(RuntimeContext commandRequest, RequestHandler requestHandler,
+ WorkFlowManager workflowManager) {
+ super(commandRequest, requestHandler, workflowManager);
}
-
@Override
- public void onRequestCompletion(RuntimeContext request, CommandResponse response) {
- super.onRequestCompletion(request, response, true);
+ public void onRequestCompletion(CommandResponse response) {
+ super.onRequestCompletion(response, true);
}
@Override
public void run() {
- RuntimeContext request = getCommandRequest();
+ RuntimeContext request = commandRequest;
final CommonHeader commonHeader = request.getRequestContext().getCommonHeader();
final boolean forceFlag = commonHeader.getFlags().isForce();
UniqueRequestIdentifier requestIdentifier = new UniqueRequestIdentifier(commonHeader.getOriginatorId(), commonHeader.getRequestId(), commonHeader.getSubRequestId());
private static final String TTL_FLAG= "TTL";
private static final String API_VERSION= "2.0.0";
private static final String ORIGINATOR_ID= "1";
- private LCMCommandTask executionTask;
- private LCMReadonlyCommandTask LCMReadonlyCommandTask;
private CommandTaskFactory factory ;
private RequestHandler requestHandler;
workflowManager = Mockito.mock(WorkFlowManager.class);
lifecyclemanager = Mockito.mock(LifecycleManager.class );
- executionTask = new LCMCommandTask(requestHandler,workflowManager,lifecyclemanager);
- LCMReadonlyCommandTask = new LCMReadonlyCommandTask(requestHandler,workflowManager);
factory = new CommandTaskFactory();
factory.setLifecyclemanager(lifecyclemanager);
factory.setWorkflowManager(workflowManager);
@Test
public void testFactory(){
- CommandTask task = factory.getExecutionTask("Configure");
+ CommandTask task = factory.getExecutionTask("Configure", null);
assertEquals(LCMCommandTask.class,task.getClass() );
- task = factory.getExecutionTask("Sync");
+ task = factory.getExecutionTask("Sync", null);
assertEquals(LCMReadonlyCommandTask.class,task.getClass() );
}
Mockito.doNothing().when(requestHandler).onRequestTTLEnd((RuntimeContext) anyObject(),anyBoolean());
RuntimeContext request = pouplateCommandExecutorInput("FIREWALL", 30, "1.0", Instant.now(), API_VERSION, "11", ORIGINATOR_ID, "", VNFOperation.Configure, "1", "");
CommandResponse response = getCommandResponse(VNFOperation.Configure, true, "11", "","1");
- executionTask.onRequestCompletion(request, response);
+ LCMCommandTask executionTask = new LCMCommandTask(request, requestHandler,workflowManager,lifecyclemanager);
+ executionTask.onRequestCompletion(response);
}
@Test
public void testRunGetConfig(){
- RuntimeContext request = pouplateCommandExecutorInput("FIREWALL", 30, "1.0", Instant.now(), API_VERSION, "11", ORIGINATOR_ID, "", VNFOperation.Sync, "1", "");
- LCMReadonlyCommandTask.setCommandRequest(request);
- LCMReadonlyCommandTask.run();
+ RuntimeContext request = pouplateCommandExecutorInput("FIREWALL", 30, "1.0", Instant.now(), API_VERSION, "11", ORIGINATOR_ID, "", VNFOperation.Sync, "1", "");
+ LCMReadonlyCommandTask readonlyCommandTask = new LCMReadonlyCommandTask(request, requestHandler,workflowManager);
+ readonlyCommandTask.run();
}
@Test
public void testRun(){
- RuntimeContext request = pouplateCommandExecutorInput("FIREWALL", 30, "1.0", Instant.now(), API_VERSION, "11", ORIGINATOR_ID, "", VNFOperation.Sync, "1", "");
- executionTask.setCommandRequest(request);
+ RuntimeContext request = pouplateCommandExecutorInput("FIREWALL", 30, "1.0", Instant.now(), API_VERSION, "11", ORIGINATOR_ID, "", VNFOperation.Sync, "1", "");
+ LCMCommandTask executionTask = new LCMCommandTask(request, requestHandler,workflowManager,lifecyclemanager);
executionTask.run();
}
@Test
public void testRunNegative(){
- RuntimeContext request = pouplateCommandExecutorInput("FIREWALL", 30, "1.0", Instant.now(), API_VERSION, "11", ORIGINATOR_ID, "", VNFOperation.Sync, "1", "");
- executionTask.setCommandRequest(request);
+ RuntimeContext request = pouplateCommandExecutorInput("FIREWALL", 30, "1.0", Instant.now(), API_VERSION, "11", ORIGINATOR_ID, "", VNFOperation.Sync, "1", "");
+ LCMCommandTask executionTask = new LCMCommandTask(request, requestHandler,workflowManager,lifecyclemanager);
executionTask.run();
}
CommandResponse getCommandResponse(VNFOperation action , boolean success, String responseId, String payload, String vnfId){
- CommandResponse commandResponse = new CommandResponse();
RuntimeContext runtimeContext = new RuntimeContext();
- commandResponse.setRuntimeContext(runtimeContext);
ResponseContext responseContext = new ResponseContext();
runtimeContext.setResponseContext(responseContext);
RequestContext requestContext = new RequestContext();
responseContext.setPayload(payload);
commonHeader.setTimestamp(Instant.now());
vnfContext.setId(vnfId);
- return commandResponse;
+ return new CommandResponse(runtimeContext);
}
commandExecutor.setExecutionQueueService(executionQueueService);
LCMCommandTask lcmCommandTask = Mockito.mock(LCMCommandTask.class);
LCMReadonlyCommandTask LCMReadonlyCommandTask = Mockito.mock(LCMReadonlyCommandTask.class);
- Mockito.doReturn(lcmCommandTask).when(executionTaskFactory).getExecutionTask("Configure");
- Mockito.doReturn(LCMReadonlyCommandTask).when(executionTaskFactory).getExecutionTask("Sync");
+ Mockito.doReturn(lcmCommandTask).when(executionTaskFactory).getExecutionTask("Configure", null);
+ Mockito.doReturn(LCMReadonlyCommandTask).when(executionTaskFactory).getExecutionTask("Sync", null);
// Mockito.when(executionQueueService.putMessage((Runnable) Mockito.anyObject(),Mockito.anyLong(),(TimeUnit)Mockito.anyObject())).thenReturn(true);
}